1523577 - GeckoNetworkManager is not compatible with isolatedProcess

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

E/GeckoCrashHandler(16760): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoCrashHandler(16760): java.lang.NullPointerException: missing IConnectivityManager
E/GeckoCrashHandler(16760): at com.android.internal.util.Preconditions.checkNotNull(Preconditions.java:54)
E/GeckoCrashHandler(16760): at android.net.ConnectivityManager.<init>(ConnectivityManager.java:1404)
E/GeckoCrashHandler(16760): at android.app.ContextImpl$12.createService(ContextImpl.java:413)
E/GeckoCrashHandler(16760): at android.app.ContextImpl$ServiceFetcher.getService(ContextImpl.java:298)
E/GeckoCrashHandler(16760): at android.app.ContextImpl.getSystemService(ContextImpl.java:1838)
E/GeckoCrashHandler(16760): at android.content.ContextWrapper.getSystemService(ContextWrapper.java:562)
E/GeckoCrashHandler(16760): at org.mozilla.gecko.GeckoNetworkManager.updateNetworkStateAndConnectionType(GeckoNetworkManager.java:305)
E/GeckoCrashHandler(16760): at org.mozilla.gecko.GeckoNetworkManager.performActionsForStateEvent(GeckoNetworkManager.java:264)
E/GeckoCrashHandler(16760): at org.mozilla.gecko.GeckoNetworkManager.handleManagerEvent(GeckoNetworkManager.java:183)
E/GeckoCrashHandler(16760): at org.mozilla.gecko.GeckoNetworkManager.enableNotifications(GeckoNetworkManager.java:141)
E/GeckoCrashHandler(16760): at org.mozilla.gecko.GeckoAppShell$2.run(GeckoAppShell.java:1659)

It's calling getSystemService(Context.CONNECTIVITY_SERVICE);

All the things it listens to will have to be done in the main process.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad6118836cb3035870a3b73a8a8102e24f49fe05

Comment 2

[[:owlish] 🦉 PST]

Attachment: Bug 1523577 - Don't initialize GeckoViewStateListener in GeckoThread if on a child process

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd5376dec81c
Don't initialize GeckoViewStateListener in GeckoThread if on a child process r=geckoview-reviewers,aklotz

Comment 4

[[:owlish] 🦉 PST]

That patch^ is actually for this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1522890

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cd5376dec81c

Comment 6

[[:owlish] 🦉 PST]

Reopening as the patch above actually fixed this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1522890 <--- I updated its status

This one still needs work to do

Comment 7

[[:owlish] 🦉 PST]

Attachment: Bug 1523577 - Make sure we don't initialize tickler on child processes

Comment 8

[[:owlish] 🦉 PST]

Attachment: Bug 1523577 - Clean up dead fennec code

Depends on D108267

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e03b68ff607d
Make sure we don't initialize tickler on child processes r=necko-reviewers,valentin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30a34933ceae
Clean up dead fennec code r=geckoview-reviewers,agi

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e03b68ff607d
https://hg.mozilla.org/mozilla-central/rev/30a34933ceae