1523585 - Crash when trying to clear all logins from about:logins

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Levente Sacal]

Attachment: logcat delete all logins.txt

Device(s):

• Sony Xperia Z5 (Android 7.0);

Build(s):

• Beta 66.0b3

Steps to reproduce:

1. Go to about:logins
2. Try and delete all logins

Expected result:

• Logins are deleted without any issues

Actual result:

• Logins are deleted but Fennec crashes

Notes:

• there was no crash signature in about:crashes after restart
• have attached a logcat and video
• could not reproduce on Samsung Galaxy Tab S3 (Android 8.0), Xiaomi MiPad 2 (Android 5.1) , HTC 10 (Android 8.0)

https://youtu.be/CkYDsdK64F0

Comment 1

[Jan Henning [:JanH]]

have attached a logcat

Which doesn't include anything interesting. Can you try getting a logcat that actually captures the moment of the crash?

Comment 2

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Is 67 definitely unaffected?

Comment 3

[Levente Sacal]

Unfortunately, I wasn't able to reproduce the issue anymore so I wasn't able to catch the logcats.

Tried on Sony Xperia Z5 (Android 7.0) and Samsung S8 (Android 7.0).

Comment 4

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Can you try once more? If you can't reproduce it now, we can likely close this issue.

Comment 5

[Ioana Chiorean]

Levente is in PTO these days, Andrei can you please have a look?

Comment 6

[Andrei Bodea[:andrei]]

I wasn't able to reproduce this issue on the latest Beta build 66.0b5 and latest Nightly build 67.0a1 with the following devices:
Sony Xperia Z5 (Android 7.0), Samsung Galaxy S7(Android 7), Google Pixel 3XL(Android P).
Also, note that I tried to reproduce this issue with fresh accounts where I registered few new logins.
I will keep an eye for this issue while testing and if I will manage to reproduce it, I will add the information and re-open the issue.
Liz feel free to either change the priority of the bug or closed it.

Thanks,
Andrei

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8) (Away March 2 - 20)]

Attachment: Bug 1523585 Part 2 - Unset NS_BLOCK_MARGIN_ROOT bit for -moz-column-content to make the margin root computation correct.

NS_BLOCK_FORMATTING_CONTEXT_STATE_BITS is set on column-contents when
creating a column container on elements like <fieldset> or <button>, or
when a column container has a float style or absolute position. (See
nsCSSFrameConstructor::ConstructNonScrollableBlockWithConstructor()).

To compute block-start and block-end margin root correctly for
column-contents, we remove the bit for column-contents. This is needed
after applying the next part to avoid breaking
layout/reftests/columns/fieldset-columns-001.html

An alternative idea is that we can always compute aBStartMarginRoot or
aBEndMarginRoot for column-contents regardless NS_BLOCK_MARGIN_ROOT bit,
but it seems nicer to be consistent that NS_BLOCK_MARGIN_ROOT is not set
on all column-contents.

Depends on D43903

Comment 8

[Phabricator Automation]

Comment on attachment 9088948 [details]
Bug 1523585 Part 2 - Unset NS_BLOCK_MARGIN_ROOT bit for -moz-column-content to make the margin root computation correct.

Revision D43904 was moved to bug 1523582. Setting attachment 9088948 [details] to obsolete.