Closed Bug 1523593 Opened 9 months ago Closed 9 months ago

Local macOS build broken by homebrew-related clang change from bug 1523153 - TypeError: expected string or buffer in python/mozbuild/mozbuild/shellutil.py

Categories

(Firefox Build System :: General, defect, critical)

defect
Not set
critical

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Gijs, Assigned: standard8)

References

Details

Attachments

(1 file)

Specifically:

 0:04.81 checking for cbindgen... blah/blah/.cargo/bin/cbindgen
 0:04.83 checking cbindgen version... 0.6.8
 0:04.83 checking for rustfmt... blah/blah/.cargo/bin/rustfmt
 0:04.83 Traceback (most recent call last):
 0:04.83   File "mozilla-unified/configure.py", line 124, in <module>
 0:04.83     sys.exit(main(sys.argv))
 0:04.83   File "mozilla-unified/configure.py", line 30, in main
 0:04.83     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
 0:04.83   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 461, in run
 0:04.83     func(*args)
 0:04.83   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 505, in _value_for
 0:04.83     return self._value_for_depends(obj)
 0:04.83   File "mozilla-unified/python/mozbuild/mozbuild/util.py", line 947, in method_call
 0:04.83     cache[args] = self.func(instance, *args)
 0:04.83   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 514, in _value_for_depends
 0:04.83     return obj.result()
 0:04.83   File "mozilla-unified/python/mozbuild/mozbuild/util.py", line 947, in method_call
 0:04.83     cache[args] = self.func(instance, *args)
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 149, in result
 0:04.84     return self._func(*resolved_args)
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 1070, in wrapped
 0:04.84     return new_func(*args, **kwargs)
 0:04.84   File "mozilla-unified/build/moz.configure/bindgen.configure", line 63, in llvm_config_paths
 0:04.84     brew_config = check_cmd_output([brew, 'config']).strip()
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 1070, in wrapped
 0:04.84     return new_func(*args, **kwargs)
 0:04.84   File "mozilla-unified/build/moz.configure/util.configure", line 69, in check_cmd_output
 0:04.84     retcode, stdout, stderr = get_cmd_output(*args, **kwargs)
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 1070, in wrapped
 0:04.84     return new_func(*args, **kwargs)
 0:04.84   File "mozilla-unified/build/moz.configure/util.configure", line 46, in get_cmd_output
 0:04.84     log.debug('Executing: `%s`', quote(*args))
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/shellutil.py", line 206, in quote
 0:04.84     return ' '.join(_quote(s) for s in strings)
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/shellutil.py", line 206, in <genexpr>
 0:04.84     return ' '.join(_quote(s) for s in strings)
 0:04.84   File "mozilla-unified/python/mozbuild/mozbuild/shellutil.py", line 187, in _quote
 0:04.84     if s and not SHELL_QUOTE_RE.search(s) and not s.startswith('~'):
 0:04.84 TypeError: expected string or buffer
 0:04.88 *** Fix above errors and then restart with               "./mach build"

backing out https://hg.mozilla.org/mozilla-central/rev/22c349313334 resolves the error.

Flags: needinfo?(mh+mozilla)

The fix here should be fine and Gijs has rs'ed it, leaving NI open for Mike just in case there's something else to look at as well.

Assignee: nobody → standard8
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/1d7c85e4e922
Pass arguments to check_cmd_output as simple arguments rather than a list. Bustage fix from bug 1523153. r=Gijs a=Aryx
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

This was the right fix. Sorry for the trouble.

Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.