1523692 - layout/style/test/test_mq_prefers_reduced_motion_dynamic.html fails under e10s

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

It looks like test_mq_prefers_reduced_motion_dynamic.html does some things to mock certain "reduced motion" preferences, but this doesn't work with GeckoView in e10s mode. The mocked values are set in the parent process, but the content process doesn't use them.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

:hiro, can you look into this?

Comment 2

[Hiroyuki Ikezoe (:hiro)]

It seems to me that the value is set via PuppetWidget, but we might use a different nsLookAndFeel instance? I am not sure yet, but will debug it.

Comment 3

[Chris Peterson [:cpeterson]]

P1 because this test failure blocks GeckoView mochitests. If this particular test case is not critical, we can temporarily disable this it.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

This should work;
https://hg.mozilla.org/try/rev/080d3c975510be462193e4d4b94ca09d4a0679ba

What we needed there is to set the prefers reduced motion value for test to the nsLookAndFeel instance in the child process as well as the one in the parent process.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1523692 - Set the prefers-reduce-motion value for test to the instance of nsLookAndFeel in child processes. r=snorp

So that we can query the test value in the child process properly.

Note that the APIs used for setting the prefers-reduced-motion value for testing
are only used on Android and MacOSX. As for MacOSX we have a different
machinery (see bug 1486971) to deliver the test value without spinning native
event loop in the child process so the change here is valid only for Android.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b771a1a88a7
Set the prefers-reduce-motion value for test to the instance of nsLookAndFeel in child processes. r=snorp

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2b771a1a88a7

Comment 8

[Chris Peterson [:cpeterson]]

Moving some e10s bugs to the new GeckoView::Sandboxing component.