Move customize mode strings over to fluent

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P5
normal
RESOLVED FIXED
5 months ago
11 days ago

People

(Reporter: Gijs, Assigned: nickcowles9575, Mentored)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 wontfix, firefox68 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

These strings live in browser.dtd

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/browser/locales/en-US/chrome/browser/browser.dtd#937-973

Instead, the relevant markup could use data-l10n-id, and then we could insert the FTL file using MozXULElement.insertFTLIfNeeded() from CustomizeMode.jsm's enter method.

Obviously this is only a small part of browser.dtd, but realistically some of it needed to be split up a long time ago, and this is one small part of starting to do that.

Comment 1

4 months ago

(In reply to :Gijs (he/him) from comment #0)

These strings live in browser.dtd

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/browser/locales/en-US/chrome/browser/browser.dtd#937-973

Instead, the relevant markup could use data-l10n-id, and then we could insert the FTL file using MozXULElement.insertFTLIfNeeded() from CustomizeMode.jsm's enter method.

Obviously this is only a small part of browser.dtd, but realistically some of it needed to be split up a long time ago, and this is one small part of starting to do that.

I'm an outreachy applicant and I would like to work on this issue. Please tell me how to start with it?

Reporter

Comment 2

4 months ago

(In reply to Nidhi Kumari from comment #1)

I'm an outreachy applicant and I would like to work on this issue. Please tell me how to start with it?

This (and the other deps of bug 1517304) is not a great place to start, unfortunately. Please talk to the mentors of the project you're interested in to find appropriate bugs for the project you want to work on.

Assignee: nobody → nickcowles9575
Status: NEW → ASSIGNED

Comment 4

3 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/71363080b33a
Move customize mode strings over to fluent, r=Gijs,jaws,flod

Comment 5

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Reporter

Updated

2 months ago
Depends on: 1544027
You need to log in before you can comment on or make changes to this bug.