Closed Bug 1523757 Opened 10 months ago Closed 7 months ago

Move app menu notification DTD strings from browser.dtd to their own ftl file

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: nautilus, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/browser/components/customizableui/content/panelUI.inc.xul#87

This panel has a number of different uses. AFAICT all the strings live in browser.dtd

They could be migrated to a separate ftl file (appMenuNotifications.ftl ). We can load it on-demand using MozXULElement.insertFTLIfNeeded in https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/browser/components/customizableui/content/panelUI.js#738 . We should probably wait for the translations to be finished in the notification we're going to show before continuing to call openPopup().

We might then need to fix some automated tests that expect the panel to show synchronously in that case.

Hey Gijs! I'm happy to work on this if it's still available.

(In reply to danielleleb12 from comment #1)

Hey Gijs! I'm happy to work on this if it's still available.

This (and the other deps of bug 1517304) is not a great place to start, unfortunately. Please talk to the mentors of the project you're interested in to find appropriate bugs for the project you want to work on.

Assignee: nobody → christian
Status: NEW → ASSIGNED
Blocks: 1539758
Assignee: christian → freychr3
Depends on: 1543493
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddb852bfc987
Convert panelUI.inc.xul to Fluent r=flod,Gijs
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.