Closed Bug 1523768 Opened 5 years ago Closed 5 years ago

light theme is not working in FF 65.0

Categories

(Firefox :: Theme, defect)

65 Branch
Unspecified
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1504766

People

(Reporter: lapmagic, Unassigned)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Since updating to FF 65.0, when I change default theme to light theme, there is no change in color using light theme. Please note, I have the menu bar enabled.

Actual results:

Nothing happens.

Expected results:

It should be very light on the top of the browser toolbars instead of the usual following of Windows 10 accent color.

In addition to this, if you add a new theme, close FF and restart it, there is a slight delay for FF to show the new theme. It starts showing the default theme and then changes to the new theme.

The image I enclosed is the way it used to look when switching to light theme pre FF 65.0. Now, it looks like a blue.. just like the default.

Comment on attachment 9039924 [details]
This is how light theme used to show in Firefox, before version 65.0.

This is how Firefox 64.02 and earlier versions or any different version than 65.0 shows the light theme. Note that it is light on top.

hi, that's the new behaviour if you have set your accent color to be used in the titlebar withing your windows 10 appearance settings unfortunately.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Component: Untriaged → Theme
OS: Unspecified → Windows 10
Resolution: --- → DUPLICATE
Attachment #9039924 - Attachment description: 3.PNG → This is how light theme used to show in Firefox, before version 65.0.

Oh ok.. thanks.

What's funny is in the latest version of Windows 10 ... version 1809... there is an issue with the title bar accent color... it is much darker (in my case, a much darker shade of blue which causes menu bar text and min max buttons to be white) than past versions of Windows 10. So one way around that was I used the light theme to color text and min max buttons black plus a userchrome file to make the menu bars the light shade of blue they have always been...but now light theme no longer works.. it is behaving like it is default theme or basically the accent color which is very dark and makes text and buttons white... so that no longer works. For now I'm using windows 10 version 1803 which doesn't have this issue. And I use default since I like the accent color it is using in 1803.

It also seems that if you add a theme to FF 65.0, when you start FF with it it is slow to show the theme... there is a small lag.

Anyway, thanks for listening, regards, Tom

Just to clarify above.. if you attempt to make the accent color lighter in the Windows 10 settings to make FF lighter on top instead of with the much darker title bar accent color, you make all colors of the accent color scheme lighter, and for example some things lose contrast like the start menu... so making accent color lighter doesn't work since it messes others things up.

Here illustrates a little better what I mean.

So in this first image, with my Windows 10 version 1803 choosing an accent color off a background and applying it to the start menu, action center, task bar and title bar (which may be checked by default) and with Firefox version 65.0 set to "Default theme", with the menu bar enabled, we see this behavior:

https://imgur.com/a/Ypsyk1X

So far so good. This seems reasonable. It's always done this.

Now if we change default theme to light theme in Firefox 65.0, because we want a lighter look say, we see this:

https://imgur.com/a/TlnSMnG

Pretty much the same looking. Essentially there is no light theme. Why even have the option if the Windows 10 accent color, that many people have set to color title bars as well as others areas of the OS, can override it?

Before FF 65.0, if you did that, and changed to light theme, with all other settings the same, you would see this:

https://imgur.com/a/vgUufPD

Notice the light theme, with the menu bar and tabs light instead of the same color blue they are in default theme, like what happens in FF 65.0.

In Windows 10 version 1809, the accent color as it applies to title bars only has changed to a much darker color. In versions 1803 and earlier, I would simply use the default theme since this worked for me. Now with this much darker color we see this:

https://imgur.com/a/Q4MMkaN

To deal with that, I used the light theme plus a userChrome.css file to make it look just like in 1803. But now with light theme not doing hardly anything, it doesn't work since the menu bar text and min max close buttons remain white.

With this new change in Windows accent color behavior, which may work fine in other areas of the operating system... it's only the title bar where the color has changed drastically, its likely many people will look to themes in FF to override this...since they want the rest of the OS colored using the accent color, and themes are no longer behaving in a helpful way.

Even more, like I mentioned, when you set FF 65.0 to use a theme that you can install from mozilla, and restart the browser.. it doesn't show the theme right away (at least for me on 1803/1809).. there is a lag... about one second as far as I can see...at first it shows the default theme then it shows the installed theme... this looks bad. I don't normally use themes (other than trying to deal with 1809 accent color issue) I just happened to notice it... it looks like it has a problem since as far as I can recall the theme should launch instantly not show two themes one after another.

This is not so much an issue for me at the moment since like I said I am using Windows 10 version 1803 and I am using the default theme. But doing anything else and I see the unexpected behaviors above - light theme not working, other themes not launching instantly with the browser etc.

The accent color in windows 10 setting is used to give the OS a uniform look with a nice color balance. If an app has a setting that allows me to change a color or theme.. then it should work... this is only sensible, other issues aside.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: