1523814 - MoreBugUrl: Add support for WineHQ Forums links

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement, P2)

Description

[Olivier F. R. Dierick]

Attachment: 0001-MoreBugUrl-Allow-WineHQ-Forums-thread-links-in-the-e.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

Tried to put a link to a WineHQ forums thread related to a reported issue in the See Also field of the bug in the WineHQ bugzilla installation.

Actual results:

Link rejected with the error:
--- start ---
https://forum.winehq.org/viewtopic.php?f=11&t=31262 is not a valid URL to a bug. See Also URLs should point to one of:

show_bug.cgi in a Bugzilla installation.
A bug on launchpad.net
An issue on code.google.com.
A bug on bugs.debian.org.
An issue in a JIRA installation.
A ticket in a Trac installation.
A bug in a MantisBT installation.
A bug on sourceforge.net.
An issue on github.com.

--- end ---

Expected results:

'See Also' fields should accept links to forum threads where the related issue is discussed.

Comment 1

[Olivier F. R. Dierick]

Hello,

Attached is a patch that adds support for WineHQ Forums thread links to the MoreBugUrl extension.
The patch is based on the master branch.

It stems from the enhancement proposal at: https://bugs.winehq.org/show_bug.cgi?id=45912

Regards

Comment 2

[Olivier F. R. Dierick]

How can I move this bug forward?

Comment 3

[Olivier F. R. Dierick]

Hello,

Still waiting for someone to react.

Regards.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Hey Olivier, thanks for your patience.

I'll alert the upstream Bugzilla maintainers to your patch. I think they are using Freenode since mozilla's IRC has been replaced with Matrix.

Did you intend this for upstream Bugzilla or bugzilla.mozilla.org?

If you want the Mozilla instance of Bugzilla to take the patch (I'm not sure if that makes sense):

1. Clone this bug into the bugzilla.mozilla.org product and the bug editing component
2. Clone the repo from https://github.com/mozilla-bteam/bmo and follow the instructions to get it running in a container.
3. Take your patch (above) and test it to confirm it still works against master, then make a pull request
4. Take the URL of your pull request and make it a text attachment to the new bug
5. Your patch will get reviewed and once we're all happy with it, it'll get merged and deployed

Comment 5

[Olivier F. R. Dierick]

Hello,

It's intended for upstream Bugzilla.

Wine is widely used for running Windows programs on Linux and Mac OS X platforms, and many commercial and open projects have stemmed from it. Users of Wine are encouraged to discuss issues outside the WineHQ.org bugzilla instance, in the WineHQ.org forums. The goal of the patch is to allow any bugzilla instance that relate to Wine or downstream projects to refer to WineHQ.org forum topics, starting with the WineHQ.org bugzilla instance itself. Otherwise, bugzilla instances would have to be patched locally.

Regards.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

This patch doesn't cleanly apply to 5.2. If it did I'd merge it. https://github.com/bugzilla/bugzilla/

Comment 7

[Olivier F. R. Dierick]

Attachment: 0001-MoreBugUrl-Allow-WineHQ-Forums-thread-links-in-the-e.patch

Hello,

Here is the updated patch, rebased against origin/5.2 and modified according to the indentation changes from commit 7f3a749 and revert from 'use parent' to 'use base' from commit 6eafd6a.

Regards.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Commited and pushed.

https://github.com/bugzilla/bugzilla/commit/7fa2374fe7f153b288e97c5eb542c849360336c7

Thanks for the patch!

Comment 9

[Olivier F. R. Dierick]

Hello,

The new file 'extensions/MoreBugUrl/lib/WineHQForums.pm' is missing from the commit.

Regards.

Comment 12

[stuntstand5]

The WineHQ Bugzilla system should accept forum thread links in the 'See Also' field for related issue discussions.

Comment 13

[stuntstand5]

The WineHQ Bugzilla system should accept forum thread links in the 'See Also' field for related issue discussions.

Comment 14

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] Bug 1523814 - Add missing WineHQForums.pm (#199)

Comment 15

[Dave Miller [:justdave]]

Comment on attachment 9423362 [details] [review]
[bugzilla/bugzilla] Bug 1523814 - Add missing WineHQForums.pm (#199)

(duplicate)

Comment 16

[Dave Miller [:justdave]]

Comment on attachment 9423363 [details] [review]
[bugzilla/bugzilla] Bug 1523814 - Add missing WineHQForums.pm (#199)

Landed on 5.2 branch:
https://github.com/bugzilla/bugzilla/commit/ec8da3c92f29c5a2421ffac2ff6cf7bb5139a419

Comment 17

[Dave Miller [:justdave]]

Does this exist on Harmony?

Comment 18

[buovjaga]

(In reply to Dave Miller [:justdave] from comment #17)

Does this exist on Harmony?

The extension is not in Harmony yet.

Comment 19

[Dave Miller [:justdave]]

Ah that's bug 1917419. Looks good. :-)