1523942 - Optimize ThreadActor._mapSourceToAddon

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

SourceActor._mapSourceToAddon:
https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/devtools/server/actors/source.js#243-290

This function is called for all sources on SourceActor instantiation:
https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/devtools/server/actors/source.js#153

But it is:

• only useful for add-ons
• slow to execute

We should:

• bail out the earliest/fastest when we know it isn't an addon resource
• even if this is an add-on resource, optimize this computation

We can surely optimize it if we merge SourceActor._mapSourceToAddon with mapURIToAddonId:
https://searchfox.org/mozilla-central/source/devtools/server/actors/utils/map-uri-to-addon-id.js#34-42
And adapt this code to the fact that we only support WebExtension add-ons.
The possible URL scheme for WebExtension is most likely much simplier and probably restricted to only one kind.
Also WebExtensionPolicy.getByURI may be faster than the original platform method we used to call when we orignaly wrote this helper method.

Comment 1

[Alexandre Poirot [:ochameau]]

Oh wait, it is even much more simple. We aren't using "addonPath". We return it in the form, but never use it elsewhere.

https://searchfox.org/mozilla-central/search?q=addonPath&case=false&regexp=false&path=devtools%2F

It looks like we can remove a lot of code.

Comment 2

[Alexandre Poirot [:ochameau]]

As well as addonID:
https://searchfox.org/mozilla-central/search?q=addonID&case=true&regexp=false&path=devtools%2F

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1523942 - Remove unused addonID/addonPath from SourceActor.

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10b9532c8fc6b028f48a975ecdbc96ae86fd9ad1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfdfbd4fa2ce
Remove unused addonID/addonPath from SourceActor. r=jlast

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bfdfbd4fa2ce