1523943 - Cache SourceActor.url

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/devtools/server/actors/source.js#177-180
get url() {
if (this.source) {
return getSourceURL(this.source, this.threadActor._parent.window);
}
return this._originalUrl;
},

We are spending a significant time into SourceActor.url getter.
See this profile: http://bit.ly/2Rty0U6 related to bug 1523937.

And it appears that we are accessing the url getter many times, while getSourceURL isn't that fast to execute.
It would be beneficial for performance to cache the computed url.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1523943 - Cache SourceActor.url.

Depends on D18244

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ab76cc4232f
Cache SourceActor.url. r=jlast

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0ab76cc4232f