1524131 - Mac OS X leak when calling LaunchChild (launchchild_osx.mm) from updater.cpp

Status: NEW

(Toolkit :: Application Update, defect, P3)

Description

[Robert Strong (they/them - no direct email)]

Direct leak of 44 byte(s) in 1 object(s) allocated from:
#0 0x106f55233 in wrap_malloc (/usr/local/opt/llvm/lib/clang/7.0.1/lib/darwin/libclang_rt.asan_osx_dynamic.dylib:x86_64+0x59233)
#1 0x7fff6cefe8b2 in _Block_copy (/usr/lib/system/libsystem_blocks.dylib:x86_64+0x8b2)
#2 0x7fff6ce7703b in _dispatch_Block_copy (/usr/lib/system/libdispatch.dylib:x86_64+0x203b)
#3 0x7fff6ce8ea12 in _dispatch_source_set_cancel_handler (/usr/lib/system/libdispatch.dylib:x86_64+0x19a12)
#4 0x106f5457e in wrap_dispatch_source_set_cancel_handler (/usr/local/opt/llvm/lib/clang/7.0.1/lib/darwin/libclang_rt.asan_osx_dynamic.dylib:x86_64+0x5857e)
#5 0x7fff44ee7d46 in _CFMachPortCreateWithPort2 (/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation:x86_64+0x70d46)
#6 0x7fff47038eb8 in -[NSMachPort initWithMachPort:options:] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x48eb8)
#7 0x7fff47066c07 in -[NSMachPort init] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x76c07)
#8 0x7fff47066b66 in +[NSPort port] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x76b66)
#9 0x7fff471fc3da in -[NSConcreteTask launchWithDictionary:error:] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x20c3da)
#10 0x7fff471fac4b in +[NSTask launchedTaskWithLaunchPath:arguments:] (/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation:x86_64+0x20ac4b)
#11 0x106ec7e24 in LaunchChild(int, char const**) (<updates-dir>/updater.app/Contents/MacOS/org.mozilla.updater:x86_64+0x100010e24)
#12 0x106ebf6e7 in LaunchCallbackAndPostProcessApps(int, char**, int, bool) (<updates-dir>/updater.app/Contents/MacOS/org.mozilla.updater:x86_64+0x1000086e7)
#13 0x106ec0a4d in main (<updates-dir>/updater.app/Contents/MacOS/org.mozilla.updater:x86_64+0x100009a4d)
#14 0x7fff6ceb0014 in start (/usr/lib/system/libdyld.dylib:x86_64+0x1014)

Comment 1

[Stephen A Pohl [:spohl]]

Similar to bug 1523622, this callstack seems to indicate that it is actually the OS that's leaking this object and I'm not confident that we're going to be able to address this...