markdown generated by approval comment form could be improved

RESOLVED FIXED

Status

()

defect
--
minor
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: glob, Assigned: kohei)

Tracking

Staging

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

the comments generated by the approval comment generator are a bit hard on the eyes

-=-=-=-=-

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

personalized recommendations would appear in private browsing

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

covered by test, but manual str if desired would be to check for the header via network monitor on a private window.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

minimal change

String changes made/needed

none

-=-=-=-=-

playing around it looks a bit more readable with the next step down of headers

-=-=-=-=-

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

personalized recommendations would appear in private browsing

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

covered by test, but manual str if desired would be to check for the header via network monitor on a private window.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

minimal change

String changes made/needed

none

-=-=-=-=-

Agreed. Making the change now.

Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Component: General → Extensions: BMO
Component: Extensions: BMO → Extensions: FlagTypeComment

Merged to master.

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

It could be further improved by using a table.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9040313 - Attachment is obsolete: true

Actually I didn’t use a table, because it cannot contain line breaks. On GitHub <br> works but on Bugzilla HTML tags will be escaped…

Status: REOPENED → ASSIGNED

v2 merged to master.

Status: ASSIGNED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED

I just was Bug 1522923 Comment 5 and this is much better!

You need to log in before you can comment on or make changes to this bug.