Closed Bug 1524239 Opened 1 year ago Closed 1 year ago

Attach the LayersId of the process-top-level layer that has focus to keyboard events

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Fission Milestone M2
Tracking Status
firefox67 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Whiteboard: [fission-event-m1])

Attachments

(1 file)

In APZCTreeManager::ReceiveInputEvent attach the LayersId from bug 1524236 to the keyboard event using the field from bug 1524226.

So one question is whether we actually need to store this information in the input event itself. Right now the results of the APZ hit test are returned to the caller via the ScrollableLayerGuid out-param in ReceiveInputEvent code and the guid contains the LayersId. We also have this InputAPZContext mechanism that we use in a bunch of places (e.g. here) to stash the APZ hit-test result on the stack and then access it like so. In this example it's used to propagate it from TabParent to TabChild, but we could just as easily use it in the DispatchCrossProcessEvent code to figure out which content process to send it to.

Priority: -- → P3

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)

So one question is whether we actually need to store this information in the input event itself. Right now the results of the APZ hit test are returned to the caller via the ScrollableLayerGuid out-param in ReceiveInputEvent code and the guid contains the LayersId.

That might not be the right LayersId, though.

Consider a mouse event over a non-scrollable OOP iframe inside a scrollable parent frame. The guid computed for APZ purposes will reference the nearest enclosing scrollable layer, which in this case is the parent, but presumably we want to dispatch the event to the process of the OOP iframe.

Oh, this bug is about keyboard events.

I think my point is still valid, but should have been made in bug 1524226 instead :)

Whiteboard: [fission-event-m1]
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67540efd30a3
Attach the LayersId of the process-top-level layer that has focus to keyboard events. r=botond
Fission Milestone: --- → M2
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.