Don't detect Intel M processors with varying clock speeds as low-end

RESOLVED WONTFIX

Status

()

enhancement
P3
normal
RESOLVED WONTFIX
4 months ago
2 months ago

People

(Reporter: Gijs, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 affected)

Details

Reporter

Description

4 months ago

Intel M processors can have a base clock speed of e.g. 1.2Ghz, and then a "turbo mode" of e.g. 2.9Ghz. It seems these get registered as "just" 1.2Ghz and it throws off our detection.

:chutten, do you know if we have the top speed information anywhere else (please forward as appropriate!)? I guess we have processor info somewhere else if all else fails, but I'd prefer not to rely on that...

Flags: needinfo?(chutten)
Reporter

Updated

4 months ago
See Also: → 1523838

Comment 1

4 months ago

As far as I know we don't have anything more than we're currently reporting via sysinfo. The Telemetry Environment only has access to a single MHz. The mechanism we get this from is getSysInfoProperty("cpuspeed", ...), which gets this (on Windows) from the registry thusly.

Looks like we use WMI Classes in nsAppRunner to query a few things. Maybe we can get it to look up a Win32_Processor array for us and make MaxClockSpeed available on sysinfo?

Since I'm not the person to ask, the person I'd ask about these things is :aklotz.

Flags: needinfo?(chutten) → needinfo?(aklotz)

Looks to me like issuing the CPUID instruction would do the trick: its output contains flags indicating whether turbo boost is present, and also provides baseline and maximum clock speeds. Of course, the CPUID output format differs between Intel and AMD chips, so be careful. Note that there is a compiler intrinsic for CPUID.

Though I suppose WMI would probably abstract the processor differences away, but WMI is not exactly a lightweight API either ;-)

Flags: needinfo?(aklotz)
Reporter

Comment 3

2 months ago

Wontfixing this as we'll be removing this code.

Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.