ImageCacheKey should use the right method to check if a window is 3rd party

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

https://searchfox.org/mozilla-central/rev/6e3cc153566f5f288ae768a2172385b8436d61dd/image/ImageCacheKey.cpp#135-137

As the comment says, we are checking here if a window is a 3rd party tracker. The correct function to use is: nsContentUtils::IsThirdPartyTrackingResourceWindow().

Note that this is just an optimization, because nsContentUtils::StorageDisabledByAntiTracking(), in the end, after several steps, calls IsThirdPartyTrackingResourceWindow() here:

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/toolkit/components/antitracking/AntiTrackingCommon.cpp#969-972

Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c980928bd2d7
ImageCacheKey should use the right method to check if a window is 3rd party, r=Ehsan
Blocks: 1516540
Assignee: nobody → amarchesini
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.