1524313 - ImageCacheKey should use the right method to check if a window is 3rd party

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement)

Description

[Andrea Marchesini [:baku]]

https://searchfox.org/mozilla-central/rev/6e3cc153566f5f288ae768a2172385b8436d61dd/image/ImageCacheKey.cpp#135-137

As the comment says, we are checking here if a window is a 3rd party tracker. The correct function to use is: nsContentUtils::IsThirdPartyTrackingResourceWindow().

Note that this is just an optimization, because nsContentUtils::StorageDisabledByAntiTracking(), in the end, after several steps, calls IsThirdPartyTrackingResourceWindow() here:

https://searchfox.org/mozilla-central/rev/78cd247b5d7a08832f87d786541d3e2204842e8e/toolkit/components/antitracking/AntiTrackingCommon.cpp#969-972

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1524313 - ImageCacheKey should use the right method to check if a window is 3rd party, r?ehsan

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c980928bd2d7
ImageCacheKey should use the right method to check if a window is 3rd party, r=Ehsan

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c980928bd2d7