1524373 - Assert on missing resumeAfter.

Status: NEW

(Core :: JavaScript Engine: JIT, enhancement, P5)

Description

[Nicolas B. Pierron [:nbp]]

Benjamin lost a week investigating Bug 1522458. The up-coming patch should raise an assertion if a resumeAfter is obviously missing on a VM call.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1524373 - Assert on missing calls to IonBuilder::resumeAfter.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57cd5dcd01a2
Assert on missing calls to IonBuilder::resumeAfter. r=jandem

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 57cd5dcd01a2 (bug 1524373) for causing spidermonkey build bustage

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=15afb7c811994f38ea8b67c8437c25f8c4e3adb0&selectedJob=225456943&searchStr=linux%2Cdebug%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-arm-sim-linux32%2Fdebug%2Csm%28arm%29

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=15afb7c811994f38ea8b67c8437c25f8c4e3adb0&selectedJob=225456943&searchStr=linux%2Cdebug%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-arm-sim-linux32%2Fdebug%2Csm%28arm%29

backout: https://hg.mozilla.org/integration/autoland/rev/8d5a09338d4f85e5047fd1a5d7e9c2f80ae9c716

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

These checks should be done only if !IsCompilingWasm(), I think.