1524604 - The search result tooltip is displayed as misplaced inside the Firefox Home Content section

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: preferences.png

Affected versions

• Firefox 67.0a1 (BuildId:20190201093730).
• Firefox 66.0b3 (BuildId:20190128143734).
• Firefox 65.0 (BuildId:20190124174741).

Unaffected versions

• Firefox 60.5.0esr (BuildId:20190124141046).

Affected platforms

• Windows 10 64bit.
• macOS 10.11.6
• Ubuntu 18.04 64bit

Steps to reproduce

1. Launch Firefox.
2. Access the about:preferences page.
3. Enter the number 3 inside the “Find in Options” searchbar (any number between 1 - 4 will do).
4. Observe the Firefox Home Content section.

Expected result

• The search result tooltip is displayed above the rows dropdown list.

Actual result

• The search result tooltip is misplaced

Regression range

• I think that this issue was introduced with Bug 1465172 which added the section rows.

Additional notes

• For further information regarding this issue, please observe the attached screenshot

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1524604 - Surround the Activity Stream dropdowns with a box so the search tooltip is positioned correctly. r?k88hudson

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1999a751e5db
Surround the Activity Stream dropdowns with a box so the search tooltip is positioned correctly. r=k88hudson

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1999a751e5db

Comment 4

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 67.0a1 (BuildId:20190206215551) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 18.04 64bit.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take this in beta if you can request uplift.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9040825 [details]
Bug 1524604 - Surround the Activity Stream dropdowns with a box so the search tooltip is positioned correctly. r?k88hudson

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1465172

User impact if declined

Users searching for a string that is inside of the dropdowns that appear within the Activity Stream area will get a search tooltip that is misplaced

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

none

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This change uses the same technique that is used throughout the Preferences to properly align tooltips for dropdowns

String changes made/needed

none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9040825 [details]
Bug 1524604 - Surround the Activity Stream dropdowns with a box so the search tooltip is positioned correctly. r?k88hudson

Fix verified in nightly, let's take it for beta 10.

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6ecdb201bbdb

Comment 9

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 66.0b10 (BuildId:20190221160854) on Windows 10 64bit, macOS 10.12 and Ubuntu 16.04 64bit.