1524655 - Flip `dom.push.alwaysConnect` to true

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, enhancement, P2)

Description

[Lina Butler (ex-Mozilla)]

This has now been rolled out via Shield to everyone on release, so let's flip the pref (https://searchfox.org/mozilla-central/rev/e62b311b2e0e02633afda2004ba4056b09fbcaa4/modules/libpref/init/all.js#5216) to true and uplift to Beta.

Comment 1

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug and there is no activity for 2 weeks.
:overholt, could you have a look please?

Comment 2

[Lina Butler (ex-Mozilla)]

Phil and JR, would you mind creating accounts on Phabricator so I can send you reviews for Desktop patches? 😉 Thanks!

Comment 3

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1524655 - Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey

Also, remove a test that's no longer relevant, since we don't need to
fetch all subscriptions at startup.

Comment 4

[JR Conlin [:jrconlin,:jconlin]]

✔️ phabricator

Comment 5

[Philip Jenvey [:pjenvey]]

Done

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88ea72c345ab
Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey

Comment 7

[Dorel Luca [:dluca]]

Backed out changeset 88ea72c345ab (bug 1524655) for mochitest failures in dom/push/test/test_error_reporting.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233817923&repo=autoland&lineNumber=33606

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-e10s-2&revision=88ea72c345aba0ede0433cc0db9e86bff5525bc1

Backout:
Backed out changeset 88ea72c345ab (bug 1524655) for mochitest failures in dom/push/test/test_error_reporting.html

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab709310d23f
Backed out changeset 88ea72c345ab for mochitest failures in dom/push/test/test_error_reporting.html

Comment 9

[Lina Butler (ex-Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d05d427023f055a9f1cdccc37a14b2cdbb95ee1c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f32dc8409c3d
Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f32dc8409c3d

Comment 12

[Chris Mills [:cmills]]

After discussion with :lina, it sounds like we don't need a release note or MDN docs on this, so removing DDN.