Flip `dom.push.alwaysConnect` to true

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
20 days ago

People

(Reporter: lina, Assigned: lina)

Tracking

(Depends on 1 bug)

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago

This has now been rolled out via Shield to everyone on release, so let's flip the pref (https://searchfox.org/mozilla-central/rev/e62b311b2e0e02633afda2004ba4056b09fbcaa4/modules/libpref/init/all.js#5216) to true and uplift to Beta.

The priority flag is not set for this bug and there is no activity for 2 weeks.
:overholt, could you have a look please?

Flags: needinfo?(overholt)
(Assignee)

Updated

3 months ago
Assignee: nobody → lina
Mentor: lina
Status: NEW → ASSIGNED
Flags: needinfo?(overholt)
(Assignee)

Comment 2

3 months ago

Phil and JR, would you mind creating accounts on Phabricator so I can send you reviews for Desktop patches? 😉 Thanks!

Flags: needinfo?(pjenvey)
Flags: needinfo?(jrconlin)
(Assignee)

Comment 3

3 months ago

Also, remove a test that's no longer relevant, since we don't need to
fetch all subscriptions at startup.

✔️ phabricator

Flags: needinfo?(jrconlin)

Done

Flags: needinfo?(pjenvey)
Priority: -- → P2

Comment 6

2 months ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88ea72c345ab
Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey

Backed out changeset 88ea72c345ab (bug 1524655) for mochitest failures in dom/push/test/test_error_reporting.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233817923&repo=autoland&lineNumber=33606

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-e10s-2&revision=88ea72c345aba0ede0433cc0db9e86bff5525bc1

Backout:
Backed out changeset 88ea72c345ab (bug 1524655) for mochitest failures in dom/push/test/test_error_reporting.html

Flags: needinfo?(lina)

Comment 8

2 months ago
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab709310d23f
Backed out changeset 88ea72c345ab for mochitest failures in dom/push/test/test_error_reporting.html
Attachment #9044476 - Attachment description: Bug 1524655 - Remove `dom.push.alwaysConnect` and connect unconditionally. → Bug 1524655 - Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey

Comment 10

2 months ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f32dc8409c3d
Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey

Comment 11

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

After discussion with :lina, it sounds like we don't need a release note or MDN docs on this, so removing DDN.

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.