1524693 - Add "Android 7.0 x86-64" to thPlatformMap

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Geoff Brown [:gbrown]]

Bug 1498298 adds tests for Android 7.0 running against x86_64 builds. I'd like a new entry in thPlatformMap:

'android-em-7-0-x86_64': 'Android 7.0 x86-64',

(I feel 'Android 7.0 x86_64', with an underscore, would be more appropriate, but we already have 'Android 5.0 x86-64', so let's be consistent.)

Comment 1

[Geoff Brown [:gbrown]]

As an aside, what I'd really like is for treeherder to display what I send it, even if the name contains spaces or periods -- then we wouldn't need these thPlatformMap updates. I suppose there's a good reason that can't happen?

Comment 2

[Ed Morley [:emorley]]

(In reply to Geoff Brown [:gbrown] from comment #1)

As an aside, what I'd really like is for treeherder to display what I send it

Agreed - that's bug 1458560.

Comment 3

[Geoff Brown [:gbrown]]

Bug 1498298 landed using "Android-7_0-x86_64" as the platform:

https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/taskcluster/taskgraph/transforms/tests.py#605

For consistency, I think it best if we add the thPlatformMap entry as specified in comment 0, then update taskcluster to send "android-em-7-0-x86_64".

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4573

Comment 5

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder/commit/870b24438eeae9eeeaf33bd4871a485ffd299aa5