Closed Bug 1524693 Opened 2 years ago Closed 2 years ago

Add "Android 7.0 x86-64" to thPlatformMap

Categories

(Tree Management :: Treeherder: Frontend, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gbrown, Assigned: aryx)

References

Details

Attachments

(1 file)

Bug 1498298 adds tests for Android 7.0 running against x86_64 builds. I'd like a new entry in thPlatformMap:

'android-em-7-0-x86_64': 'Android 7.0 x86-64',

(I feel 'Android 7.0 x86_64', with an underscore, would be more appropriate, but we already have 'Android 5.0 x86-64', so let's be consistent.)

As an aside, what I'd really like is for treeherder to display what I send it, even if the name contains spaces or periods -- then we wouldn't need these thPlatformMap updates. I suppose there's a good reason that can't happen?

(In reply to Geoff Brown [:gbrown] from comment #1)

As an aside, what I'd really like is for treeherder to display what I send it

Agreed - that's bug 1458560.

Bug 1498298 landed using "Android-7_0-x86_64" as the platform:

https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/taskcluster/taskgraph/transforms/tests.py#605

For consistency, I think it best if we add the thPlatformMap entry as specified in comment 0, then update taskcluster to send "android-em-7-0-x86_64".

Attachment #9041965 - Flags: review?(cdawson) → review+
Assignee: nobody → aryx.bugmail
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1526113
You need to log in before you can comment on or make changes to this bug.