1524818 - audioipc fails to build with nightly Rust: "error: use of deprecated item 'std::error::Error::cause': replaced by Error::source, which can support downcasting"

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Botond Ballo [:botond]]

I tried to build m-c with nightly Rust, and got some errors in the audioipc crate:

4:15.72 error: use of deprecated item 'std::error::Error::cause': replaced by Error::source, which can support downcasting
 4:15.72   --> media/audioipc/audioipc/src/errors.rs:10:1
 4:15.72    |
 4:15.72 10 | / error_chain! {
 4:15.72 11 | |     // Maybe replace with chain_err to improve the error info.
 4:15.72 12 | |     foreign_links {
 4:15.72 13 | |         Bincode(bincode::Error);
 4:15.72 ...  |
 4:15.72 21 | |     }
 4:15.72 22 | | }
 4:15.72    | |_^
 4:15.72    |
 4:15.72    = note: `-D deprecated` implied by `-D warnings`
 4:15.72    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
 4:15.72 error: use of deprecated item 'std::error::Error::cause': replaced by Error::source, which can support downcasting
 4:15.72   --> media/audioipc/audioipc/src/errors.rs:10:1
 4:15.72    |
 4:15.72 10 | / error_chain! {
 4:15.72 11 | |     // Maybe replace with chain_err to improve the error info.
 4:15.72 12 | |     foreign_links {
 4:15.72 13 | |         Bincode(bincode::Error);
 4:15.72 ...  |
 4:15.72 21 | |     }
 4:15.72 22 | | }
 4:15.72    | |_^
 4:15.72    |
 4:15.72    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
 4:15.72 error: aborting due to 2 previous errors

Comment 1

[Matthew Gregan [:kinetik]]

This is an unfortunate interaction with a crate used by audioipc (error_chain) and warnings-as-errors.

Upstream error_chain bug: https://github.com/rust-lang-nursery/error-chain/issues/254

We can work around this until it's fixed upstream by silencing the deprecation warnings.

Comment 2

[Matthew Gregan [:kinetik]]

Workaround: https://github.com/djg/audioipc-2/pull/54

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18fc86b209a4
Update audioipc to c2148b95 to fix build with nightly rustc.  r=chunmin

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/18fc86b209a4