152504 - JavaScript error while leaving File Bookmark dialog (treecols has no properties)

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Adam Hauner]

Repro:
1. open several tabs
2. open File Bookmark dialog...
3. check 'Bookmark this group of tabs'
4. hit Cancel

Actual:
Error: treecols has no properties
Source File: 
Line: 12

2002061712/trunk/W2K

Comment 1

[Stefan Borggraefe]

Confirming. This also happens when you leave the File Bookmark-dialog with the
OK-Button or via the close button of the dialog. Furthermore the state of the
Bookmark this group of tabs-checkbox does not matter.

Build-ID 2002061707/WinXP.

Tuning summary a bit so this bug can be found easier. Lowering severity.

Comment 2

[David G King]

What annoys me about this bug is that the Source File isn't specified. I don't
know if this is something about this bug, or something about the Javascript console.

In any case, the Source File problem will be fixed by Bug# 52116, so marking
this as dependant on that bug.

Comment 3

[Pierre Chanial]

taking, but low priority

Comment 4

[David G King]

OK, I did a bit of digging, and apologies if I'm nowhere near the right place.

In mozilla/xpfe/components/bookmarks/resources/bookmarks.xml treecols is used in
three places (ignoring the definition statements). In lines 1950, 2048 and 2103.
The first two are used like this - <treecols anonid="treecols">, but the last
one is just <treecols>.

Could this be the problem? (I would test myself, but I'm on Win98 and I can't
afford to buy MSVC++).

Comment 5

[Pierre Chanial]

good catch David!
To make your first patch: use PatchMaker in
http://www.gerv.net/software/patch-maker/build-mode.html
You don't need to have MSVC to modify chrome files.

Comment 6

[David G King]

OK, give me a bit of time (i.e. a day or so) to download/install the programs,
and I'll see what I can do.

Thanks Pierre for letting me have a go at this.

Comment 7

[David G King]

Attachment: Fix for JS error treecols has no properties

This is my first attempt at a patch, so apologies if I've done something wrong.

Comment 8

[Pierre Chanial]

Comment on attachment 93490 [details] [diff] [review]
Fix for JS error treecols has no properties

r=[e-mail]
You should ask Blake to sr.

Comment 9

[David G King]

I'm dropping the severity level as I don't beleive this bug actually prevents
any functionality from working. Well, when I get the error, it's always after
successfully performing a bookmark function.

If someone is getting this error, and a failure in Bookmarks, please let me know.

Also, I'm seeking an sr on my patch. eMail to Blake bounced, so I sent an eMail
to Ben.

And finally, I was going to set the target milestone to 1.1, but there is no
such entry. However, that is what I'm aiming for. Which brings up a question, is
anyone seeing this problem on the 1.0.1 branch?

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 93490 [details] [diff] [review]
Fix for JS error treecols has no properties

sr=[e-mail]

Comment 11

[André Dahlqvist]

*** Bug 172026 has been marked as a duplicate of this bug. ***

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in