./mach bootstrap should not try to use/get `rustup` when using artifact builds

RESOLVED FIXED in Firefox 67

Status

RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Gijs, Assigned: froydnj)

Tracking

Trunk
mozilla67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago

As per topic.

  1. vanilla machine, download m-c, run ./mach bootstrap
  2. pick 'firefox for desktop artifact builds'

ER:
doesn't attempt to install/upgrade rust

AR:
attempts to install/upgrade rust.

Commenting out https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/python/mozboot/mozboot/bootstrap.py#444 seems to help.

(Assignee)

Comment 1

2 months ago
This is the "official" way to comment this call out.
Attachment #9041204 - Flags: review?(gijskruitbosch+bugs)
(Reporter)

Comment 2

2 months ago
Comment on attachment 9041204 [details] [diff] [review]
avoid downloading rust packages when bootstrapping for artifact builds

Thanks!
Attachment #9041204 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

2 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ebaff11acf7
avoid downloading rust packages when bootstrapping for artifact builds; r=Gijs

Comment 4

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → nfroyd
You need to log in before you can comment on or make changes to this bug.