1525090 - Use AddonListeners for HTML about:addons views

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Mark Striemer [:mstriemer]]

The first cut of the list view won't update based on add-on changes. This means you need to perform a refresh to see any add-ons that were just installed and for themes disabling the active theme won't necessarily show which theme has become active.

Instead of updating the state on interactions it should be updated when the add-ons themselves change.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525090 - Use AddonListeners in HTML about:addons

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0c893a00bf
Use AddonListeners in HTML about:addons r=aswan,Gijs

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/cf0c893a00bf

Comment 4

[Mark Striemer [:mstriemer]]

With this change the following situations should work (all for an open about:addons window when the action is performed):

• Removing an extension from its browser action context menu removes it from about:addons.
• Installing an extension or theme will add it to the list.
• Switching themes should always show 1 enabled and the rest disabled.
  • This seemed to work before but it was a race between theme start and shutdown.
• Opening two about:addons tabs and making changes in one will have them reflected in the other.
• Changing the theme in the customize tab should update in about:addons.

Comment 5

[CosminB]

Attachment: Bug1525090.gif

This issue is verified as fixed on Firefox 68.0a1 (20190320112939) and 67.0b3 (20190318154932) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.