1525119 - Dedicated profiles don't get locked to the default browser install

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Dave Townsend [:mossop]]

When choosing the old default profile as the new dedicated profile when the app is the default browser we're meant to "lock" the profile to this install so others won't choose it later. Not sure how I failed to catch this in tests but this doesn't work because we try to get an XPCOM component before XPCOM is started.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1525119: Check if this is the default install and if so lock the profile. r=froydnj

Previously we attempted to do this when XPCOM wasn't available so it always
failed to get the shell service. Instead set a flag telling us to do it later
when we choose the old default profile.

Also includes a block of code to attempt to fix the issue for existing nightly
users, this can be removed before betas.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c132ef1b7c8a
Check if this is the default install and if so lock the profile. r=froydnj

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c132ef1b7c8a