Closed Bug 1525156 Opened 1 year ago Closed 1 year ago

Add Telemetry to know how many autoplay media, which has been resumed from blocked, played more than 7 secs

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

This bug will add telemetry to know how many autoplay media, which has been blocked by autoplay policy before, played more than 7 secs, after it allowed to play from blocked status.

Priority: -- → P2

"blocked" event is used for blocking autoplay. The AudioChannelAgentBlockedPlay() returns true when
we lost audio focus on Android, so actually we don't need to dispatch "blocked" event.

Attached file Data review request
Attachment #9041971 - Flags: review?(chutten)
Comment on attachment 9041971 [details]
Data review request

Preliminary notes:
From a data design point-of-view it might make more sense to record this as a pair of linear or exponential histograms: One recording the length of time previously-blocked video was played, and one recording the length of time previously-blocked audio was played. You could use the number of samples in each bucket to determine how many video/audio elements were played for which durations.

If you do decide to change the shape of the collection, ni?me on this bug and we'll see if this Data Review still holds (it probably will).

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file ([Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json)), the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/), and on telemetry.mozilla.org's [Measurement Dashboards](https://telemetry.mozilla.org/new-pipeline/dist.html).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection expires in Firefox 72.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :alwu is responsible for renewing or removing the collection before it expires in Firefox 72.

---
Result: datareview+
Attachment #9041971 - Flags: review?(chutten) → review+
Attachment #9041345 - Attachment description: Bug 1525156 - part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played more or less than 7 secs. → Bug 1525156 - part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds.

In order to get the correct measurement of the total played time, we should modify the way we use mPlayTime.

(1) mPlayTime should be paused when entering the bf-cache if it has been started
(2) mPlayTime should be restarted again when leaving the bf-cache if the media element is playing
(3) mPlayTime should be reset if media element abort the current load

Attachment #9041345 - Attachment description: Bug 1525156 - part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds. → Bug 1525156 - part3 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds.
Attachment #9041345 - Attachment description: Bug 1525156 - part3 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds. → Bug 1525156 - part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds.
Attachment #9044014 - Attachment is obsolete: true
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adb554a755e5
part1 : not dispatch event when play is rejected by AudioChannelAgent. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/0a003a54ff45
part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds. r=cpearce,janerik
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.