1525188 - Reloading local file in RDM makes the tab go blank, reload forever, and permanently break

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Brad Werth [:bradwerth]]

Steps to Reproduce:

1. Load a local html file.
2. Open Dev Tools and view it in Responsive Design Mode.
3. Reload.

The tab hangs, showing a blank page.

mozregression shows that this push is responsible: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7bcedc06aad40dc1fca97af177f62bc14b27fd54&tochange=e39bd319fe3e2d8e310467fa65bc2a8eab398992. I can't see the details of Bug 1522546 to confirm.

Comment 1

[Brad Werth [:bradwerth]]

Mike, would you please take a look? This appears to be triggered by your work on Bug 1522546.

Comment 3

[Daniel Holbert [:dholbert]]

Adjusting summary slightly for clarity; the tab doesn't technically "hang" in the sense of running code forever, but rather it just goes blank & stops working (while playing the reload animation).

Also, this error appears in the Browser Console when this happens:

Security Error: Content at moz-nullprincipal:{6977aed8-6876-435d-a1a2-796e6360851c} may not load or link to file:///.

(The numeric UUID there is different each time, FWIW).)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Looking.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Putting this in the security bucket because this was caused by a security patch I landed. Discussion about the patches I post will likely refer to the changes I landed in that other bug.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fead571a5fafd39ed47e2412208863f6892eb55e

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1525188 - Don't set remoteType attributes when swapping frameLoaders. r?nika

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1525188 - Tunnel the remoteType properly from the outer to inner browser in RDM, and remember to clean up. r?ochameau

Depends on D19220

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/49291c19d3e2
https://hg.mozilla.org/mozilla-central/rev/25d09fd7954c

Comment 10

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version on Nightly from 2019-02-04 on Windows 10 x64.
I retested everything using the latest Nightly 68.0a1 and Firefox 67.0b11 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.