1525273 - PhabBugs feed stuck - null `text` in story feed

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect, P1)

Description

[:glob ✱]

Use of uninitialized value in length at local/lib/perl5/Mojo/IOLoop/Stream.pm line 37.
Use of uninitialized value in length at local/lib/perl5/Mojo/IOLoop/Stream.pm line 37.
{"Fields":{"msg":
   "Undef did not pass type constraint \"Str\" (in $_[3]) at /app/extensions/PhabBugz/lib/Feed.pm line 194
    \"Str\" is a subtype of \"Value\"
    \"Value\" is a subtype of \"Defined\"
    Undef did not pass type constraint \"Defined\" (in $_[3])
    \"Defined\" is defined as: (defined($_))
"},
"Hostname":"ip-172-31-26-183.us-west-2.compute.internal",
"Logger":"STDERR",
"Pid":"8",
"Type":"Bugzilla.Extension.PhabBugz.Feed",
"Timestamp":1549374690000000000,
"EnvVersion":2,
"Severity":0
}

Comment 1

[:glob ✱]

possibly related:

{"Fields":{"msg":"Fetching new stories","type":"FEED"},...}
Use of uninitialized value in length at local/lib/perl5/Mojo/IOLoop/Stream.pm line 37.
Use of uninitialized value $story_text in concatenation (.) or string at /app/extensions/PhabBugz/lib/Feed.pm line 163.

Comment 2

[:glob ✱]

looks like the code is expecting a text field in the feed.query_id api response, however it isn't present in any of the responses:

    {
      "id": "240173",
      "phid": "PHID-STRY-hfxsoodfxkkywhzfcjza",
      "class": "PhabricatorApplicationTransactionFeedStory",
      "epoch": 1549373626,
      "authorPHID": "PHID-USER-p7a62wknonfqkih2zlnc",
      "chronologicalKey": "6654509054567392063",
      "data": {
        "objectPHID": "PHID-DREV-3zthelxzzye4kerlhool",
        "transactionPHIDs": {
          "PHID-XACT-DREV-nm2nzcmubzv7mng": "PHID-XACT-DREV-nm2nzcmubzv7mng",
          "PHID-XACT-DREV-svpypg2rjy7lnh2": "PHID-XACT-DREV-svpypg2rjy7lnh2",
          "PHID-XACT-DREV-yo4ffrkei2hvc4o": "PHID-XACT-DREV-yo4ffrkei2hvc4o"
        }
      }
    },

Comment 3

[:glob ✱]

ah, the text field isn't returned by default when using the feed.query_id web ui.

    {
      "id": "240173",
      "phid": "PHID-STRY-hfxsoodfxkkywhzfcjza",
      "class": "PhabricatorApplicationTransactionFeedStory",
      "epoch": 1549373626,
      "authorPHID": "PHID-USER-p7a62wknonfqkih2zlnc",
      "chronologicalKey": "6654509054567392063",
      "objectPHID": "PHID-DREV-3zthelxzzye4kerlhool",
      "text": null
    },

dkl found the corresponding story here: https://phabricator.services.mozilla.com/feed/6654509054567392063/

that text is null is the crux of the problem.

Comment 4

[:glob ✱]

this is https://phabricator.services.mozilla.com/D17238#477275

this comment was "Signed with MFA", and https://secure.phabricator.com/w/changelog/2019.05/

"Signed With MFA" stories are now hidden from feed.

if possible we'll disable the ability to sign comments with mfa.

Comment 5

[David Lawrence [:dkl]]

The feed issue is fixed now by manually updating the DB to bypass the offending feed story. This is due to a new feature where you can MFA sign transactions such as comments, etc. We will be disabling this new feature in another bug to keep this from occurring in the future.