Control + clicking should not synthesise contextmenu event on Linux

NEW
Unassigned

Status

enhancement
P3
normal
4 months ago
3 months ago

People

(Reporter: ato, Unassigned)

Tracking

(Blocks 1 bug)

Version 3
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

4 months ago

In https://bugzilla.mozilla.org/show_bug.cgi?id=1421323 we changed
the actions API to synthesise a contextmenu event on macOS and
Linux, but not Windows. I asked as part of the review whether this
applied to Linux, which was confirmed.

But https://github.com/mozilla/geckodriver/issues/1492 and various
comments on the aforementioned bug disagree. The conclusion I draw
from the user feedback is that we should not be firing the contextmenu
event on Linux, but instead have the same behaviour as on Windows,
which is to open a new tab.

Reporter

Updated

4 months ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 1

4 months ago

Hi Andreas, I'm one of the people who gave feedback on the original issue and I just want to point out that the original behaviour (for Firefox < 62) was not to open a new tab, but to send ctrl+click to the browser and let it handle it (and yes, ctrl+clicking a link opens a new tab, but our issue was with multiselect on custom elements that was handled in javascript).

Reporter

Comment 2

4 months ago

Hi asmigala,

(In reply to asmigala from comment #1)

I'm one of the people who gave feedback on the original issue and
I just want to point out that the original behaviour (for Firefox
< 62) was not to open a new tab, but to send ctrl+click to the
browser and let it handle it (and yes, ctrl+clicking a link opens
a new tab, but our issue was with multiselect on custom elements
that was handled in javascript).

Yes, thanks for pointing this out. I actually thought about this
distinction after I had left work yesterday. You are entirely
correct.

To that point, I think our mouse synthesiser indeed will not open
a new tab on Control + click, because it blocks any form of interaction
that would transcend into the browser chrome.

Summary: Control + clicking on a link should not synthesise contextmenu event on Linux → Control + clicking should not synthesise contextmenu event on Linux
Reporter

Updated

3 months ago
Assignee: ato → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
You need to log in before you can comment on or make changes to this bug.