1525350 - Contents of find bar not cleared from private browsing window

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P3)

Description

[Andrew McCreight [:mccr8]]

STR:

1. Visit a web page not in private browsing mode.
2. Open a new private browsing window.
3. Visit some web site in the private browsing window.
4. Hit command-f (on OSX) to search for something in the page.
5. Close the private browsing window.
6. In the non-private browsing window, hit command-f. The page search from step 4 is still there.

Expected behavior: In step 6, I'd have expected that the search input I typed in for step 4 is not there any more. It isn't page content per se, but it is within the browsing window, and is something explicitly tied to that particular private browsing page.

Comment 1

[(no longer active)]

Mike, I believe this bug is caused by clipboardSearchString in the findbar code...

It looks to me that a fix would look like doing a private browsing check on this._getWindow() around here and only performing the assignment if we're in a non-private window. Does that sound right to you?

Comment 2

[Mike de Boer [:mikedeboer]]

Yes, that sounds right. I would put it in the clipboardSearchString setter to catch all callsites.

Comment 5

[ian]

Attachment: Bug 1525350 - Check if window is private before saving search string. r=NeilDeakin

Comment 6

[ian]

Hi Neil, I have submitted a patch for this. This is my first time attempting to do this in the Mozilla ecosystem, so please let me know if I screwed something up. Thanks!

Comment 7

[Neil Deakin]

Thank you, I have landed the patch for you.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b9bc18499dc
Check if window is private before saving search string. r=NeilDeakin

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/1b9bc18499dc

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 100.0(20220428192727) on macOS 11. Verified as fixed on Firefox 101.0b8(20220517185920) and Nightly 102.0a1(20220517212638) on macOS 11.