Closed
Bug 1525397
Opened 6 years ago
Closed 6 years ago
Remove lsan suppressions from webrtc wpt
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(1 file)
This list of suppressions is scary:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webrtc/__dir__.ini#2
| Assignee | ||
Updated•6 years ago
|
Rank: 25
| Assignee | ||
Updated•6 years ago
|
Rank: 25 → 15
Priority: P3 → P2
| Assignee | ||
Updated•6 years ago
|
Assignee: nobody → docfaraday
| Assignee | ||
Comment 1•6 years ago
|
||
| Assignee | ||
Comment 2•6 years ago
|
||
Ok... disabling the suppressions did not hurt try at all.
jgraham, is there some testing that the wpt sync bot is running that is not on try?
Flags: needinfo?(james)
Comment 3•6 years ago
|
||
All the tests are on try, but those lsan failures are only from the asan job, so in practice you just need to run that one. I would certainly retrigger a few times though since many leaks are intermittent.
Flags: needinfo?(james)
| Assignee | ||
Comment 4•6 years ago
|
||
Retriggered ASAN a bunch of times. Let's see what happens.
| Assignee | ||
Comment 5•6 years ago
|
||
40 asan retriggers worked fine.
| Assignee | ||
Updated•6 years ago
|
Summary: webrtc web-platform-tests leak like crazy → Remove lsan suppressions from webrtc wpt
| Assignee | ||
Comment 6•6 years ago
|
||
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dde97a187bfd
Disable LSAN suppressions in webrtc wpt. r=jib
Comment 8•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•