1525406 - Having the toolbox open alongside browser mochitests spams the terminal window

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P2)

Description

[Mark Banner (:standard8)]

If I run something like:

./mach mochitest --tag=quantumbar --jsdebugger browser/components/urlbar/tests/browser/browser_urlbarSearchFunction.js

Then once the toolbox starts up, there is lots of spam to the terminal/console window.

This makes it hard for me to see the test output.

Typical sort of logs:

0:04.00 GECKO(21736) [ACTION] ADD_SOURCES  - {"type":"ADD_SOURCES","sources":[{"id":"sourceURL-resource:///modules/ZoomUI.jsm","url":"resource:///modules/ZoomUI.jsm","relativeUrl":"resource:///modules/ZoomUI.jsm","isPrettyPrinted":false,"sourceMapURL":null,"introductionUrl":null,"isBlackBoxed":false,"loadedState":"unloaded","isWasm":false}],"sourceActors":[{"actor":"server2.conn0.source92","source":"sourceURL-resource:///modules/ZoomUI.jsm","thread":"server2.conn0.context22"}]}
 2:36.15 GECKO(21736) [ACTION] COMMAND [start] - {"type":"COMMAND","command":"resume","thread":"server2.conn0.context22","seqId":"26","status":"start"}
 2:36.20 GECKO(21736) [ACTION] RESUME  - {"type":"RESUME","thread":"server2.conn0.context22"}
 2:36.20 GECKO(21736) [ACTION] EVALUATE_EXPRESSIONS  - {"type":"EVALUATE_EXPRESSIONS","inputs":[],"results":[]}
 2:36.21 GECKO(21736) [ACTION] COMMAND [done] - {"type":"COMMAND","command":"resume","thread":"server2.conn0.context22","seqId":"26","status":"done","value":{"from":"server2.conn0.context22","type":"resumed"}}

Is there some way we can turn this off?

Comment 1

[Brian Grinstead [:bgrins]]

Those messages look like they are coming from the debugger frontend via some kind of redux logging. Jason, is there a pref to disable this?

Comment 2

[Mark Banner (:standard8)]

I discovered that I could work around this by commenting out this section:

https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/devtools/client/debugger/new/src/actions/utils/middleware/log.js#97-104

Comment 3

[Jason Laster [:jlast]]

We should probably only show these logs if we're running debugger mochitests. I can update the check to be more specific.

Comment 4

[Jason Laster [:jlast]]

I believe this has been fixed.

Comment 5

[David Walsh :davidwalsh]

We a pref to prevent this now: debugger.log-actions

Comment 6

[Mark Banner (:standard8)]

I don't see any setting of this preference for mochitests, so we're still spamming the console for those.

Comment 7

[Mark Banner (:standard8)]

I just tried setting this in testing/profiles/common/user.js, I also tried setting it to false in the two cases I could find, here and here.

Unfortunately none of those worked, I'm still getting console spam.

Comment 8

[David Walsh :davidwalsh]

Attachment: Bug 1525406 - Only log actions when desired r=standard8

Prevents any output coming from the debugger logging actions

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f89081950bb
Only log actions when desired r=Standard8

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5f89081950bb