Closed Bug 1525406 Opened 7 months ago Closed 3 months ago

Having the toolbox open alongside browser mochitests spams the terminal window

Categories

(DevTools :: Debugger, task, P2)

task

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: standard8, Assigned: davidwalsh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [debugger-mvp])

Attachments

(1 file)

If I run something like:

./mach mochitest --tag=quantumbar --jsdebugger browser/components/urlbar/tests/browser/browser_urlbarSearchFunction.js

Then once the toolbox starts up, there is lots of spam to the terminal/console window.

This makes it hard for me to see the test output.

Typical sort of logs:

0:04.00 GECKO(21736) [ACTION] ADD_SOURCES  - {"type":"ADD_SOURCES","sources":[{"id":"sourceURL-resource:///modules/ZoomUI.jsm","url":"resource:///modules/ZoomUI.jsm","relativeUrl":"resource:///modules/ZoomUI.jsm","isPrettyPrinted":false,"sourceMapURL":null,"introductionUrl":null,"isBlackBoxed":false,"loadedState":"unloaded","isWasm":false}],"sourceActors":[{"actor":"server2.conn0.source92","source":"sourceURL-resource:///modules/ZoomUI.jsm","thread":"server2.conn0.context22"}]}
 2:36.15 GECKO(21736) [ACTION] COMMAND [start] - {"type":"COMMAND","command":"resume","thread":"server2.conn0.context22","seqId":"26","status":"start"}
 2:36.20 GECKO(21736) [ACTION] RESUME  - {"type":"RESUME","thread":"server2.conn0.context22"}
 2:36.20 GECKO(21736) [ACTION] EVALUATE_EXPRESSIONS  - {"type":"EVALUATE_EXPRESSIONS","inputs":[],"results":[]}
 2:36.21 GECKO(21736) [ACTION] COMMAND [done] - {"type":"COMMAND","command":"resume","thread":"server2.conn0.context22","seqId":"26","status":"done","value":{"from":"server2.conn0.context22","type":"resumed"}}

Is there some way we can turn this off?

Those messages look like they are coming from the debugger frontend via some kind of redux logging. Jason, is there a pref to disable this?

Flags: needinfo?(jlaster)
Priority: -- → P3

We should probably only show these logs if we're running debugger mochitests. I can update the check to be more specific.

Flags: needinfo?(jlaster)
Component: General → Debugger
Priority: P3 → P2

I believe this has been fixed.

Flags: needinfo?(dwalsh)
Blocks: node-dx

We a pref to prevent this now: debugger.log-actions

Status: NEW → RESOLVED
Closed: 3 months ago
Flags: needinfo?(dwalsh)
Resolution: --- → FIXED

I don't see any setting of this preference for mochitests, so we're still spamming the console for those.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I just tried setting this in testing/profiles/common/user.js, I also tried setting it to false in the two cases I could find, here and here.

Unfortunately none of those worked, I'm still getting console spam.

Flags: needinfo?(dwalsh)

Prevents any output coming from the debugger logging actions

Assignee: nobody → dwalsh
Status: REOPENED → ASSIGNED
Flags: needinfo?(dwalsh)
Whiteboard: [debugger-mvp]
Type: enhancement → task
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f89081950bb
Only log actions when desired r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.