152541 - After deleting remembered query it is still in page footer

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Arne Schirmacher]

Delete a remembered query. The "Query is gone" page shows the page footer with
the deleted query name still in place. All following page footers are ok though.

This happens with 2.16rc2 and and 2.17 (bugzilla.mozilla.org).

Comment 1

[Bradley Baetz (:bbaetz)]

Thats because GetUserInfo has already pushed the stored queries into the
appropriate template var.

userprefs.cgi calls GetUserInfo again, and adding a thing to the footer manually
pushes the var.

We need to remove this particular entry from the $::vars->{'user'}->{'queries'}
array.

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: v1

Remove the appropriate entry....

Comment 3

[Bradley Baetz (:bbaetz)]

-> me

Comment 4

[Bradley Baetz (:bbaetz)]

Oh, and ignore the last hunk of the patch - I forgot to save my edited patch
before attaching it.

Comment 5

[Jouni Heikniemi]

Comment on attachment 88109 [details] [diff] [review]
v1

Without the last hunk, 2xr=jouni

Comment 6

[Bradley Baetz (:bbaetz)]

Checked in, trunk + branch

Comment 7

[Gervase Markham [:gerv]]

Yep, sorry. I think I caught the added query case, but not the deleted one. <sigh>

Gerv

Comment 8

[Bradley Baetz (:bbaetz)]

*** Bug 153915 has been marked as a duplicate of this bug. ***