windows/aarch64 - toolkit/components/ctypes/tests/unit/test_jsctypes.js | xpcshell return code: -1073741819
Categories
(Core :: js-ctypes, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: away)
References
Details
Attachments
(1 file)
#[markdown(off)]
Filed by: egao [at] mozilla.com
https://treeherder.mozilla.org/logviewer.html#?job_id=226206279&repo=try
|
||
Comment 1•5 years ago
|
||
Is this intermittent or permanent? Later in the test suite execution there is also this failure
test_ext_runtime_getPlatformInfo.js | - Architecture is valid - false == true
Similar platform issues could have also caused the ctype issue.
|
||
Comment 2•5 years ago
•
|
||
(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #1)
Is this intermittent or permanent? Later in the test suite execution there is also this failure
test_ext_runtime_getPlatformInfo.js | - Architecture is valid - false == true
Similar platform issues could have also caused the ctype issue.
It is uncertain whether this is an intermittent or a permafail for win10/aarch64 hardware. I suspect it is a permafail until a fix is applied, though there isn't additional runs to verify this.
I will update the bug summary accordingly after a verification run.
As for the subsequent failure, I believe that should be logged as a separate bug.
|
||
Comment 3•5 years ago
|
||
I am not sure why test_jsctypes.js is failing here for windows on arm64, the detailed log doesn't help much.
Possibly we should make sure this test doesn't run in parallel, maybe running it sequentially similar to this:
https://searchfox.org/mozilla-central/source/devtools/shared/adb/test/xpcshell.ini#10
:m_kato, do you know more about this test (test_jsctypes.js) and could help figure this out?
|
||
Comment 4•5 years ago
|
||
(In reply to Edwin Gao (:egao) from comment #2)
(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #1)
Is this intermittent or permanent? Later in the test suite execution there is also this failure
test_ext_runtime_getPlatformInfo.js | - Architecture is valid - false == true
Similar platform issues could have also caused the ctype issue.It is uncertain whether this is an intermittent or a permafail for win10/aarch64 hardware. I suspect it is a permafail until a fix is applied, though there isn't additional runs to verify this.
validArchs should have aarch64 in https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/test_ext_runtime_getPlatformInfo.js#8
toolkit/components/ctypes/tests/unit/test_jsctypes.js | xpcshell return code: -1073741819
log doesn't have crash stack by 0xc0000005. So I need attach debugger when running test.
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 6•5 years ago
•
|
||
Try push with modification let validArchs = ["arm", "x86-32", "x86-64", "aarch64"]; has completed running.
Taskcluster: https://taskcluster-artifacts.net/G05FQ86WR3qxc0zR-JrGVw/0/public/logs/live_backing.log
The following errors are no longer reproducible after the change:
TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_runtime_getPlatformInfo.js | - Extension left running at test shutdown - "running" == "unloaded"
TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_runtime_getPlatformInfo.js | - Architecture is valid - false == true
TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_runtime_getPlatformInfo.js | xpcshell return code: 0
Still reproducible is the following:
TEST-UNEXPECTED-FAIL | toolkit/components/ctypes/tests/unit/test_jsctypes.js | xpcshell return code: -1073741819
|
|
||
Comment 7•5 years ago
|
||
TEST-UNEXPECTED-FAIL | toolkit/components/ctypes/tests/unit/test_jsctypes.js | xpcshell return code: -1073741819
dmajor, do you know root cause that aarch64 windows doesn't pass jsctypes test?
This trampoline... https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/js/src/ctypes/libffi/src/aarch64/ffi.c#910
...does not have execute permission, only PAGE_READWRITE. I bet some piece of libffi's ifdef horror isn't considering arm64.
I added ARM64_WIN64 to every line that mentioned X86_WIN32 and X86_WIN64.
This makes sure the allocation routines do the proper VirtualProtect on the trampolines.
|
|
||
Comment 10•5 years ago
|
||
I can re-run the suite after the patch is merged to m-c.
:needinfo myself
|
|
Assignee | |
Comment 11•5 years ago
|
||
mach test toolkit/components/ctypes/tests/unit/test_jsctypes.js passes with this patch. I haven't run the other suites.
|
||
Comment 12•5 years ago
|
||
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/430f461b9636 Teach libffi/src/closures.c about ARM64_WIN64 r=froydnj
|
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
|
||
Comment 14•5 years ago
•
|
||
Re-ran the test locally with a build run after this patch has been integrated to m-c.
Issue cannot be reproduced. Confirm this has been fixed for opt-xpcshell-6.
From the test run locally:
17:19:27 INFO - TEST-PASS | toolkit/components/ctypes/tests/unit/test_jsctypes.js | took 26725ms
Description
•