XDRScript should create JSScript with valid constructor arguments
Categories
(Core :: JavaScript Engine, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(3 files)
In Bug 1451284 we have issues with coverage misbehaving that stem from XDR decoding.
We initialize the coverage data structures before the filename is properly set when something is OwnSource. We should code things in the appropriate order so that we can call JSScript::Create with legal values.
Assignee | ||
Comment 1•5 years ago
|
||
Sanity check was reading out-of-range value. This caused more XDR decode
failures than expected, but non-cache load would recover anyways. With
fix, a few more cases will support XDR caching.
Assignee | ||
Comment 2•5 years ago
|
||
This ensures the script source is properly ininitialized before calling
JSScript::Create. This fixes issues with LCov when the script comes from
an XDR-based cache.
Depends on D18873
Assignee | ||
Comment 3•5 years ago
|
||
There is no existing bug, but passing correct values to constructor is
more predictable for future.
Depends on D18874
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
(Changing reviewers based on workload/availability)
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41ba287d84da Fix bug in XDRState::codeCString r=jandem,nbp https://hg.mozilla.org/integration/autoland/rev/c4e1215ffff6 XDR ScriptSource before Script r=jandem https://hg.mozilla.org/integration/autoland/rev/d6729b60b236 Pass source extents to JSScript constructor in XDRScript r=jandem
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41ba287d84da
https://hg.mozilla.org/mozilla-central/rev/c4e1215ffff6
https://hg.mozilla.org/mozilla-central/rev/d6729b60b236
Description
•