OrientationPendingPromise must resolve after the change event fires

RESOLVED FIXED in Firefox 67

Status

()

P3
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: jyherman, Assigned: marcosc)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

As covered in this PR, the pending promise should only resolve after the event is fired https://github.com/w3c/screen-orientation/pull/147

The issue was first raised here https://github.com/w3c/screen-orientation/issues/120 and there is further discussion in the promises guide https://github.com/w3ctag/promises-guide/issues/57

(Assignee)

Updated

a month ago
Assignee: nobody → mcaceres
(Assignee)

Updated

a month ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
(Assignee)

Updated

a month ago
Summary: Resolve the screen orientation pending promise after the change event is fired → OrientationPendingPromise must resolve after the change event fires
(Assignee)

Comment 1

a month ago

spec was changed so promise resolves after the event fires.

Comment 3

a month ago
Pushed by mcaceres@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60cf625574a9
Resolve OrientationPendingPromise after change event fires r=baku

Comment 4

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.