1525634 - "Lazy browser prematurely inserted via 'messageManager'" when moved lazy tab into new window

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Oriol Brufau [:Oriol]]

1. Let a window have 4 tabs, activate the 1st one.
2. Enable session restore, restart Firefox, focus that window.
3. Press Shift and click the 3rd tab so that tabs 1,2,3 are multiselected with the 1st active.
4. Open browser console
5. Right-click a multiselected tab, chose "Move Tabs > Move to New Window"

The console shows

[bug 1345098] Lazy browser prematurely inserted via 'messageManager' property access:
getter@chrome://browser/content/tabbrowser.js:2081:37
handleEvent@chrome://browser/content/parent/ext-browser.js:458:11
addTab@chrome://browser/content/tabbrowser.js:2583:5
addWebTab@chrome://browser/content/tabbrowser.js:2267:12
adoptTab@chrome://browser/content/tabbrowser.js:3842:18
adoptRemainingTabs@chrome://browser/content/tabbrowser.js:3705:9
_beginRemoveTab@chrome://browser/content/tabbrowser.js:3031:5
swapBrowsersAndCloseOther@chrome://browser/content/tabbrowser.js:3294:10
onLoad@chrome://browser/content/browser.js:1410:9
EventHandlerNonNull*@chrome://browser/content/browser.xul:105:19

https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/browser/components/extensions/parent/ext-browser.js#458

The 3rd tab in the new window is in fact lazy thanks to bug 1521346. The message above refers to the 3rd tab in the old window, which stops being lazy while being closed. It's not that bad but shouldn't happen.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1525634 - Preserve lazyness of the old tab when adopted by another window. r=jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f65d978f17f
Preserve lazyness of the old tab when adopted by another window. r=jaws

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5f65d978f17f