1525635 - Failed mozAddonManager installs don't properly cancel

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

If a mozAddonManager fails for some reason in isUsableAddon, the addon is still installed but just disabled.

This could happen, for instance, if an addon AMO was marked for a particular version.

It's also going to happen with our new whitelisting policy.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Cancel the install if appDisabled is true

aswan:

So I believe this is the right thing to do (the same thing we do here):

https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1815

What I'm having trouble with is how we would notify the user in this case (we need a browser) and if we can somehow communicate this back to the createInstall so it actually fails. Right now, the install just sits there.

Any ideas?

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1525635 - Properly handle mozAddonManager compatibility failure.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba745ab8ec4a
Properly handle mozAddonManager compatibility failure. r=aswan

Comment 4

[Andreea Pavel [:apavel]]

Backed out for linting failure

Backout: https://hg.mozilla.org/integration/autoland/rev/5f6a77f08081eeab95938e4dc15af5674c933871

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/203309bfe541
Properly handle mozAddonManager compatibility failure. r=aswan

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/203309bfe541