Closed Bug 1525673 Opened 7 months ago Closed 7 months ago

Make wrapping non-wrapper-cached objects deal with multiple globals per compartment

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Right now we check js::IsWrapper to decide whether to JS::AutoRealm, but in the new world we may be different-Realm but not have a wrapper if we're same-compartment.

Maybe I need to audit our js::IsWrapper callsites. :(

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/100d9de169ab
Don't assume that same-compartment means same-realm in WrapNewBindingNonWrapperCache.  r=peterv
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.