1525718 - fix incognito permission when in permanent private browsing

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

I'm guessing that we're not giving the extension permission early enough in this case, or something. Anyway, use the STR from bug 1525712, but on restart you'll see errors for all the builtin extensions. No need to install additional extensions.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1525718 fix setting private permission when private browsing

Setting the permission has to happen after the call to parseManifest so
it may be set if the manifest is already cached.

Comment 3

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a80ca713fbf22a5b2e770d44b5a3649d4785c00

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc5290f750f15b85039ba9936e7d74856295f87f

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa1f6433408
fix setting private permission when private browsing r=rpl

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5fa1f6433408

Comment 7

[CosminB]

Attachment: Bug1525718.png

I was able to reproduce the issue on Firefox 67.0a1 (20190219213951) under Win 7 64-bit.

This issue is verified as fixed on Firefox 67.0a1 (20190226215106) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.