Closed Bug 1525718 Opened 5 years ago Closed 5 years ago

fix incognito permission when in permanent private browsing

Categories

(WebExtensions :: General, defect, P1)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox67 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- verified

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1525718 fix setting private permission when private browsing
47 bytes, text/x-phabricator-request
Details | Review
Bug1525718.png
276.87 KB, image/png
Details

I'm guessing that we're not giving the extension permission early enough in this case, or something. Anyway, use the STR from bug 1525712, but on restart you'll see errors for all the builtin extensions. No need to install additional extensions.

Setting the permission has to happen after the call to parseManifest so
it may be set if the manifest is already cached.

Assignee: nobody → mixedpuppy
Summary: builtin extensions fail on startup with permanent private browsing → fix incognito permission when in permanent private browsing
Attachment #9041923 - Attachment description: Bug 1525718 fix setting private permission on system addons → Bug 1525718 fix setting private permission when private browsing
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fa1f6433408
fix setting private permission when private browsing r=rpl

https://hg.mozilla.org/mozilla-central/rev/5fa1f6433408

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Attached image Bug1525718.png —

I was able to reproduce the issue on Firefox 67.0a1 (20190219213951) under Win 7 64-bit.

This issue is verified as fixed on Firefox 67.0a1 (20190226215106) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: