Closed Bug 1525797 Opened 6 years ago Closed 6 years ago

Make web-server run straight from source

Categories

(Taskcluster :: Services, enhancement)

Product:
Taskcluster
Component:
Services
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: hassan)

References

Details

This would mean removing the requirement to yarn build and any requirement for neutrino, webpack, etc.

From what I can tell, these are the things Neutrino is doing:

  • babel with the 'class properties' plugin -- we can just not use class props until Node supports them
  • .graphql files are read as "raw" data -- we can do that with fs.readFileSync!

With this change, web-server will work very much like any other TC service, just serving a different kind of API on some different HTTP paths.

So does it mean I have to wait until this ticket is done?

My understanding of my task was that I need to first get the server working on Kubernetes. After that I will be able to make changes into how it's working. At least that's what I would like to do. I understand you don't agree and you're taking over my project? I didn't catch your reasoning on why my plan wouldn't work

Flags: needinfo?(dustin)

Bug 1522924 is more about the deployment, while this is more about the build process. I think they're largely independent and could happen in any order. If you'd like to work on this bug too, that's fine by me! I only assigned it to myself since I was the one suggesting it was necessary.

Flags: needinfo?(dustin)

The deployment goes hand in hand with the build process. I will be changing taskcluster-terraform. It's possible I will have to change the building process. This is the part of the system I am working on, and I would like it to be stable. I did express my intent to work on this (I did not create a bug, because a) what's the hurry if I haven't started on it; b) maybe you're right and this will actually end up being part of my current bug).

It seems logical to me that I am the one to break down and prioritize my tasks. I broke down and prioritized my work based on the assumption that no parts block other people.

I don't see this bug blocking anything, although you seem to be interrupting your own work to get this done. is there any particular rush about it?

Before or after this ticket is done, the Pod spec for web-server will be running something like docker run monoimage web-server/web. That's the interface betwen the build and the deploy. So these could be done in either order.

I tend to file bugs for things that I'd like to see done at some point, and I dislike telling other people to do work so I usually assign those to myself. That's all that happened here. There's no rush on this, and I'm perfectly happy if someone else (like you) does the work. Please assign it to yourself if you'd like to do so!

I am not so sure this will not interfere with my work, and I am not so sure I won't have to make these changes while working on deploy (I actually even considered this to be part of this bug but that's ok if I'm wrong). If this is something you want to do - I won't be fighting over it :) I am asking you not to work on this until I'm done - since there's no rush, and nothing is blocked, I hope I'm not asking too much? Is it OK if I make this bug dependable on this one ?

UPD. Although that way it would seem I am blocking somebody's work. Is it OK if I assign this to myself for now? I'll give it to you back, I promise :)

A dependency sounds like a good plan. And you're not blocking anything that has to be done at a particular time, so don't worry about it.

Depends on: 1522924

In the same vein, I am getting confused about the scope of my work. Is this https://bugzilla.mozilla.org/show_bug.cgi?id=1525180 also something you want to do yourself?

What happens if I actually need to get this done while working on https://bugzilla.mozilla.org/show_bug.cgi?id=1522924 ?

I'm enjoying collaborating with other members of the team on this overall project. So I want to do things that you don't want to do or don't have time to do or that are blocking your work (and the same with you=brian or you=hassan, etc.). And I'm happy to have things get done whether I do them or not. The overall scope of this overall project is getting the web UIs, including docs, running happily in a "new-style" (GKE) deployment. But that's a shared responsibility!

you don't want to do

I probably wasn't clear yesterday. I did not intend to say "I don't want to be doing this", I was hoping to say "I would like to get the ui and the server working first, and then re-iterate on that and improve the building/deployment process". And by " I'm anxious to get this done on time" I didn't mean I don't have time for this - I meant that as I view my current task, getting it work is the main priority, and improving deployment/build process comes after. The tasks have some unknowns for me, and I would like to avoid the situation where I end up spending a week on the icing when the cake is not even there yet.

When you created this ticket, I got the impression that I am not being able to break down and prioritize my own work; and also that I'm struggling to complete my work, and other people need to step in.

I see you disagree and disapprove, but I am struggling to understand where I'm wrong, what catastrophic consequences my decision can lead to, and how come you think I won't be able to complete my work on time. If I indeed not good at breaking down my work and prioritizing it, I would like some specific and constructive feedback on how to improve.

I'll close this for now, since it's not on the critical path to getting things deployed. We can re-open, or open another bug, to do this later.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Platform and Services → Services

I'll be working on this now (Hassan confirmed it's feasible to do)

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: dustin → bugzeeeeee
Blocks: docs
Status: REOPENED → ASSIGNED
No longer depends on: 1522924
Depends on: 1522924
No longer blocks: docs

I nibbled at this project a bit, and it looks like it will take me some time (several days). I think this project is a-very-nice-to-have because removing webpack will simplify the code base a great deal. However, since the service is being deployed and working just fine, and this bug can be done at any time after the Redeployable Docs project Hassan and I are currently working on is completed, I am pulling this ticket out of the project and giving it a lower priority than some other things.

Status: ASSIGNED → NEW
Assignee: bugzeeeeee → helfi92
Status: NEW → ASSIGNED

Resolved in https://github.com/taskcluster/taskcluster/commit/d468d12ba47d2c16f13c210c368911585eda98ac.

Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.