Closed Bug 1525829 Opened 3 years ago Closed 3 years ago

Please consider adding Firefox's BuildID string to Marionette's capabilities object

Categories

(Testing :: Marionette, enhancement)

enhancement
Not set
normal

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: stephend, Assigned: automatedtester)

Details

(Keywords: perf, Whiteboard: [webpagetest])

Attachments

(1 file)

tl;dr - would you please consider/look at including Firefox's BuildID, output as a string, in Marionette's capabilities object?

BuildID variable in application.ini https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/build/application.ini.in#29

WebPageTest, via its wptagent[0], gets it from Marionette's capabilities object[1] as the string browserVersion, with a sample value "67.0a1".

Since Firefox 64, navigator.buildID() no longer works, according to https://developer.mozilla.org/en-US/docs/Web/API/Navigator/buildID, so, even if it were to get it via documented means I've come across, we'd get something like this fixed one: "20181001000000".

Perhaps it could be added as a vendor-prefixed string -- moz along with the others, e.g. https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/testing/marionette/capabilities.js#409-416?

For more context, I'm close to submitting my WebPageTest perf-runs to the Mozilla Telemetry Data Pipeline (https://github.com/mozilla/wpt-api/pull/236), and an accurate browserVersion/browser_version is key (no Python-dict pun intended, but I'll take it).

Here's what we have (will have): https://github.com/mozilla/wpt-api/pull/236/files#diff-6d5e2d2375d56dbb4c662b976106321dR65

(Also helpful would be the SHA commit hash for mozilla-central for each build, available via about:buildconfig, and has a value like: https://hg.mozilla.org/mozilla-central/rev/de51545099a617602be187d1c0f68ff2a87d6fb2 but that's totally another bug, another day.)

[0] https://github.com/WPO-Foundation/wptagent/blob/f5226f6fe978f6893eedb2c2552bdefc032405ed/internal/firefox.py#L149-L150
[1] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/testing/marionette/capabilities.js#388-397

Assignee: nobody → dburns

(In reply to Stephen Donner [:stephend] from comment #0)

BuildID variable in application.ini https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/build/application.ini.in#29

Both buildid and the commit id we should be able to query via Services or a different JSM in Marionette server. That will be safer than trying to access it via that before-mentioned file.

Add buildID to returned list of capabilities when a new session is started with
Marionette. This new capability will live in moz:buildID.

Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9092cd81ee1b
Add buildID to returned capabilities list for Marionette; r=ato
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.