1525910 - QuantumBar: Pressing the down key should first go to the end of line, then open the results

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Mark Banner (:standard8)]

The behaviour of the existing URL bar when the down key is pressed is to first go to the end of line, then to open the results.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

May want to check if this is Mac only behavior, on Windows I don't see that, unless steps differ. STR?

Comment 2

[Mark Banner (:standard8)]

Just found it, this is a Mac specific thing:

https://searchfox.org/mozilla-central/rev/e6520f0a4dd5d7474c32a1164744953ea59be0d0/toolkit/components/autocomplete/nsAutoCompleteController.cpp#486-503

STR

• Type a few letters in the address bar
• Move the cursor to earlier in the text
• Press the down arrow

Expected Results

• Cursor moves to end of text, with the popup not opening.

Actual Results

• Popup opens, cursor moves to end of text.

Note, I think there's another issue where doing left-arrow doesn't close the popup. Will need to check if we have a bug for that.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It's an edge case anyway, let's move to release

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1525910 - QuantumBar: Pressing the down key should first go to the end of line, then open the results.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Mark Banner (:standard8) (afk until Friday) from comment #2)

[...]

• Press the down arrow

Expected Results

• Cursor moves to end of text, [...]

Ehsan, do you know what makes this behavior platform-specific / where this is controlled in Gecko?

Comment 6

[(no longer active)]

Yes, this is platform-specific.

Everywhere besides Mac, VK_DOWN on input controls is mapped to cmd_moveDown https://searchfox.org/mozilla-central/source/dom/xbl/builtin/ShortcutKeyDefinitionsForInputCommon.h#10. On Mac, there is no specific mapping for that key on input controls https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/dom/xbl/builtin/mac/ShortcutKeyDefinitions.cpp#9. I don't remember off the top of my head what happens when there is no built-in mapping, I suggest breaking in TextInputListener::HandleEvent() to see what event handler is picked up for the keypress event on Mac.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ee118b40f31
QuantumBar: Pressing the down key should first go to the end of line, then open the results. r=Standard8

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2ee118b40f31

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I just found this autocomplete test covering this behavior, that was added in bug 231754. Could you please check we implemented the same behavior and there are no misses?
https://searchfox.org/mozilla-central/source/toolkit/content/tests/chrome/test_autocomplete_mac_caret.xul

Comment 10

[Dão Gottwald [:dao]]

Yes, we implement the same behavior.