1525943 - We should show the identity block for web-controlled about:blank, and the identity popup should show the domain + permissions of the site controlling about:blank

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[:Gijs (he/him)]

STR:

1. open a website of your choice, e.g. https://www.mozilla.org/
2. open the web console
3. run: document.body.onclick = () => { w = window.open("about:blank", "_blank"); }
4. click somewhere in the document body
5. observe URL bar in the newly opened tab

ER:
show identity block that lets you find out who opened about:blank

AR:
it doesn't.

Comment 1

[Johann Hofmann [:johannh]]

I agree that this seems like an improvement. It might be nice to be able to convey the fact that this is an about:blank that's controlled by https://www.mozilla.org/ in the control center somehow.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1525943 - Update the identity section from the content principal URI rather than gBrowser.currentURI. r=Gijs!,nika!

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1525943 - Show identity section for web controlled about:blank. r=Gijs!

Depends on D172677

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1525943 - Update PageInfo to get URI from content principal. r=Gijs!

Comment 5

[Emma Zühlcke [:emz]]

I currently don't have time to work on this more. The WIP patches attached are not quite ready to be landed. The tricky part are the different UIs relying on the browser URI (identity panel, page info). Some need the full URI, some only the origin. Additionally some internal pages need special handling, such as the PDF viewer. I'm afraid this will need a bigger refactor.

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1525943 - Update the identity section from the content principal URI rather than gBrowser.currentURI. r=Gijs!,nika!

Comment 7

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1525943 - Show identity section for web controlled about:blank. r=Gijs!

Depends on D193803

Comment 8

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1525943 - Add associated to the identity UI - r=pbz!,Gijs!,nika!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee1bbb0ae2ca
Update the identity section from the content principal URI rather than gBrowser.currentURI. r=Gijs,nika
https://hg.mozilla.org/integration/autoland/rev/756623a58d9f
Show identity section for web controlled about:blank. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c3e4663577c4
Add associated to the identity UI - r=pbz,Gijs,nika,flod

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ee1bbb0ae2ca
https://hg.mozilla.org/mozilla-central/rev/756623a58d9f
https://hg.mozilla.org/mozilla-central/rev/c3e4663577c4