1525971 - Use protocol pools to manage fronts on target fronts

Status: NEW

(DevTools :: Framework, enhancement, P3)

Description

[Yulia Startsev [:yulia]]

We are currently managing and destroying fronts manually: https://searchfox.org/mozilla-central/source/devtools/shared/fronts/targets/target-mixin.js#475-478

We should clean this up so that we can rely on protocol.js to do this for us. Then we can remove our custom front destruction, and rely on the destroy code path from debugger-client
https://searchfox.org/mozilla-central/source/devtools/shared/client/debugger-client.js#916-918

Comment 1

[Alexandre Poirot [:ochameau]]

We are manually registering fronts into a custom Set over here:
https://searchfox.org/mozilla-central/rev/d061ba55ac76f41129618d638f4ef674303ec103/devtools/shared/fronts/targets/target-mixin.js#200-213
Instead of doing this.manage(front).
Later on, we are destroying fronts manually from here:
https://searchfox.org/mozilla-central/rev/d061ba55ac76f41129618d638f4ef674303ec103/devtools/shared/fronts/targets/target-mixin.js#438-445

Whereas we could depend on Pool and protocol.js to automatically destroy all children fronts when the TargetFront is destroyed from here:
https://searchfox.org/mozilla-central/rev/d061ba55ac76f41129618d638f4ef674303ec103/devtools/shared/fronts/targets/target-mixin.js#474-475

But this might be better time spent working on bug 1529741, which would drastically change the implementation of getFront and allow to do a massive cleanup on the server side!

Comment 2

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 3

[Chris Peterson [:cpeterson]]

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Comment 4

[Chris Peterson [:cpeterson]]

Tracking dt-fission-reserve bugs for Fission MVP until we know whether they really need to block Fission or not.

Comment 5

[Chris Peterson [:cpeterson]]

Moving old "dt-fission-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.