Initialize Intermediate Preloading in its own service
Categories
(Core :: Security Block-lists, Allow-lists, and other State, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: jcj, Assigned: leplatrem)
References
Details
(Whiteboard: [psm-backlog])
Attachments
(2 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
2.43 KB,
patch
|
Details | Diff | Splinter Review |
Bug 1404934 wired up Intermediate Preloading by initializing it in blocklist-clients.js, while it's not a blocklist.
It should be initialized (and maintained) someplace a little more clear for the long-haul.
Assignee | ||
Comment 1•6 years ago
|
||
You could move the initialization to BrowserGlue.jsm:
Services.tm.idleDispatchToMainThread(() => {
SecurityClients.initialize();
});
But we better get Thunderbird folks in the loop since it does not have browserglue
Assignee | ||
Comment 2•6 years ago
•
|
||
Jorg, do you have something like BrowserGlue.jsm
in Thunderbird?
Comment 3•6 years ago
|
||
Sure :-) - https://searchfox.org/comm-central/source/mail/components/mailGlue.js
Thanks for the heads-up.
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
Jorg, I'm sending the patch to autoland.
How do we proceed to port the few lines to maiGlue.js
? I guess I could do it, but I don't even have cloned TB...
Comment 7•5 years ago
|
||
Hi :-)
Well, I suggest you paste the lines here and tell me after which line they go using:
https://searchfox.org/comm-central/source/mail/components/mailGlue.js
I'll take care of the rest.
Would that work for you?
Assignee | ||
Comment 8•5 years ago
|
||
I didn't find exactly the same structure as in browserGlue
, but I guess it's this (_onMailStartupDone()
)
--- mailGlue.js 2019-05-22 12:55:11.678982616 +0200
+++ mailGlue.js.orig 2019-05-22 12:48:51.174554255 +0200
@@ -14,7 +14,6 @@
var {ExtensionSupport} = ChromeUtils.import("resource:///modules/ExtensionSupport.jsm");
var { L10nRegistry, FileSource } = ChromeUtils.import("resource://gre/modules/L10nRegistry.jsm");
var {AppConstants} = ChromeUtils.import("resource://gre/modules/AppConstants.jsm");
-var {RemoteSecuritySettings} = ChromeUtils.import("resource://gre/modules/psm/RemoteSecuritySettings.jsm");
// lazy module getters
@@ -183,11 +182,6 @@
const {ExtensionsUI} = ChromeUtils.import("resource:///modules/ExtensionsUI.jsm");
ExtensionsUI.checkForSideloadedExtensions();
-
- // Certificates revocation list, etc.
- Services.tm.idleDispatchToMainThread(() => {
- RemoteSecuritySettings.init();
- });
},
_handleLink(aSubject, aData) {
In case you don't have Services.tm.idleDispatchToMainThread()
, you can call .init()
directly. It only instantiates cheap objects, and won't block startup. I just mimic what's done in browserGlue for other initializations :)
Thanks!
Comment 9•5 years ago
|
||
Thanks, Mathieu. I guess you meat to add the code rather than remove it ;-)
I'll see how this works once the M-C patch has landed, that is, if I need to pull out the Services.tm.idleDispatchToMainThread()
call.
Thanks for your help.
Assignee | ||
Comment 10•5 years ago
|
||
Thanks, Mathieu. I guess you meat to add the code rather than remove it ;-)
Oh! I haven't even paid attention, I did the diff the other way :/
It looks good to me!
Comment 11•5 years ago
|
||
bugherder |
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
Thanks Mathieu, I checked with some debugging that this is really run.
Updated•4 years ago
|
Comment 14•4 years ago
|
||
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Comment on attachment 9181067 [details]
Bug 1526018 - Initialize OneCRL when GeckoView starts.
Revision D93250 was moved to bug 1667179. Setting attachment 9181067 [details] to obsolete.
Description
•