1526051 - History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Mark Banner (:standard8)]

In porting browser_autocomplete_tag_star_visibility.js to QuantumBar, I noticed it is failing when browser.urlbar.suggest.bookmark is false.

It should be returning a result for a tagged item regardless of the pref setting, but it is not.

Comment 1

[Marco Bonardo [:mak]]

hm, I wonder if we want that or not, originally we could tag bookmarks or history, but now we only allow to tag bookmarks.

Comment 2

[Marco Bonardo [:mak]]

yeah, I think I'll just change the test to expect a different behavior, we should not be showing or returning tags if bookmarks are not suggested.

Comment 3

[Marco Bonardo [:mak]]

Hm, but the added urls also have visits, so maybe the test is not wrong. Those results should be returned because the word matches on title/url, but not presented as a bookmark or a tag...

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1526051 - History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out. r=adw!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8f4200ccbb9
History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out. r=adw

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f8f4200ccbb9