History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: standard8, Assigned: mak)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Reporter

Description

3 months ago

In porting browser_autocomplete_tag_star_visibility.js to QuantumBar, I noticed it is failing when browser.urlbar.suggest.bookmark is false.

It should be returning a result for a tagged item regardless of the pref setting, but it is not.

Assignee

Comment 1

3 months ago

hm, I wonder if we want that or not, originally we could tag bookmarks or history, but now we only allow to tag bookmarks.

Assignee

Comment 2

3 months ago

yeah, I think I'll just change the test to expect a different behavior, we should not be showing or returning tags if bookmarks are not suggested.

Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee

Comment 3

3 months ago

Hm, but the added urls also have visits, so maybe the test is not wrong. Those results should be returned because the word matches on title/url, but not presented as a bookmark or a tag...

Assignee

Updated

3 months ago
Summary: QuantumBar: Allow searching for a tag even when browser.urlbar.suggest.bookmark is false → History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out

Comment 5

3 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/f8f4200ccbb9
History tagged results should be returned by the Quantum Bar even if bookmarks are filtered out. r=adw

Comment 6

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.