Enable WebRenderTextureHostWrapper for canvas

RESOLVED FIXED in Firefox 67

Status

()

defect
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 fixed)

Details

Attachments

(1 attachment, 5 obsolete attachments)

Assignee

Description

5 months ago

WebRenderTextureHostWrapper is used only for video(async ImageHost). It could be also used for canvas(sync ImageHost).

Assignee

Comment 1

5 months ago

WebRenderTextureHostWrapper::UpdateWebRenderTextureHost() does not use WebRenderAPI::RunOnRenderThread(), it could make frame canvas is rendered one frame early. That was the reason why WebRenderTextureHostWrapper was not used for canvas(sync ImageHost).

Assignee: nobody → sotaro.ikeda.g
Attachment #9042409 - Attachment is obsolete: true
Priority: -- → P3
Assignee

Comment 3

4 months ago
Posted patch wip (obsolete) — Splinter Review
Assignee

Comment 4

4 months ago
Posted patch wip (obsolete) — Splinter Review
Attachment #9043780 - Attachment is obsolete: true
Assignee

Comment 5

4 months ago
Posted patch wip (obsolete) — Splinter Review
Attachment #9044075 - Attachment is obsolete: true
Assignee

Comment 6

4 months ago
Posted patch wip (obsolete) — Splinter Review
Attachment #9044076 - Attachment is obsolete: true
Assignee

Updated

4 months ago
Attachment #9044083 - Attachment is obsolete: true
Assignee

Updated

4 months ago
Blocks: 1416645

Comment 9

4 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73b8e1b44334
Enable WebRenderTextureHostWrapper for canvas r=nical

Comment 10

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

== Change summary for alert #19505 (as of Wed, 20 Feb 2019 07:54:57 GMT) ==

Improvements:

20% glterrain windows10-64-qr opt e10s stylo 0.97 -> 0.78

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19505

Another improvement from Raptor:

== Change summary for alert #19451 (as of Mon, 18 Feb 2019 13:16:10 GMT) ==

Improvements:

5% raptor-motionmark-animometer-firefox windows10-64-qr opt 41.59 -> 43.52

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19451

Assignee

Updated

4 months ago
Blocks: 1531294
Assignee

Comment 13

4 months ago

Comment on attachment 9044105 [details]
Bug 1526213 - Enable WebRenderTextureHostWrapper for canvas

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: Canvas(WebGL/Canvas2D) performance is not good with WebRender. The patch improved talos glterrain(WebGL test) 20%.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch is relatively simple and basic implementation is already used for video playback long timer.
  • String changes made/needed: None
Attachment #9044105 - Flags: approval-mozilla-beta?

Does this only affect Firefox when WebRender is preffed on?
We're getting close to the 66 release date, so if this can wait till 67, I'd prefer to let it stay in 67.

Flags: needinfo?(sotaro.ikeda.g)
Assignee

Comment 15

4 months ago

Yes, it affect only when WebRender is preffed on. Ok, no problem to stay in 67.

Flags: needinfo?(sotaro.ikeda.g)
Attachment #9044105 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.