1526235 - Seams show up on rotated blob images

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Rares Doghi, Desktop QA]

Attachment: TextureLines.png

[Affected versions]:
Nightly 67.0a1

[Affected platforms]:
Platforms: Windows

[Steps to reproduce]:

1. Open the Firefox browser and set the gfx.webrender.all.qualified - true
2. Reach https://wetelo.com/
3. Scroll from the top a centimeter or two.

Expected Result:
The Textures from the rocket should remain intact.

Actual Results:
There is a line crossing through the Rocket.

This issue was tested on windows 10 with Nvidia GT 730 as well as Nvidia GT 1030.

Comment 1

[Rares Doghi, Desktop QA]

Please note that the same issue can be noticed on this website : https://stripe.com/terminal , unless its a different issue and you guys think I should add a different defect for it, please let me know, and please see the attachment for this website as well.

Comment 2

[Rares Doghi, Desktop QA]

Attachment: Phonelines.jpg

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Reduced test case

This is happening because we tile blob images and we're getting seams showing up between tiles when the tiles are rotated.

Comment 4

[Dzmitry Malyshau [:kvark]]

Distantly related to (but not caused by!) https://github.com/servo/webrender/pull/2850

Comment 5

[Dzmitry Malyshau [:kvark]]

Attachment: WR draw image tiles as segments

We are currently drawing tiles as separate primitives. This doesn't work well for
masking out edge AA between tiles, since they aren't aware of each other.

The change switches image tiles to be drawn as segments sharing the same header.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4db508a2d78
WR draw image tiles as segments r=gw,nical

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e4db508a2d78

Comment 8

[Rares Doghi, Desktop QA]

This issue has been fixed in Firefox Nightly 67.0a1 (2019-02-13) I will mark it Verified as Fixed.