Open Bug 1526299 Opened 2 years ago Updated 1 year ago

Handle proxy.settings properly in private browsing

Categories

(WebExtensions :: Request Handling, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: mixedpuppy, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

If a user has a proxy extension running that uses proxy.settings upgrades to a version with incognito preffed on, what do we do with the setting? We can remove it, leave it, or give the extension pbm permission.

Priority: -- → P1
Flags: needinfo?(mconca)

The bug becomes moot if we allow extensions that are already installed to be granted PBM permission during the upgrade.

Flags: needinfo?(mconca)

(In reply to Mike Conca [:mconca] from comment #1)

The bug becomes moot if we allow extensions that are already installed to be granted PBM permission during the upgrade.

Only for those extensions, not for new profiles, new installs, etc.

For now, the extension will require private permission to use this setting. Filing a bug on netwerk to see about getting support here.

Priority: P1 → P3
Depends on: 1527749

Changing the title a bit. The use case is to make an extension that uses proxy.settings work separately in normal and private windows (similar to what was done for proxy.register and proxy.onRequest).

Summary: Handle PAC settings on upgrade to incognito → Handle proxy.settings properly in private browsing

Upping this to P1 to try and get the user experience unbroken when a user needs to set an extension to run in private browsing just to get it working at all (this is currently invisible to the user). Updating bug 1527749 to try and increase that priority as well.

Priority: P3 → P1
Priority: P1 → P2
Flags: needinfo?(mixedpuppy)
Priority: P2 → P3

We currently don't allow proxy.settings to be used without private browsing permission. I haven't heard anything from proxy addon authors about it (including secure proxy) so I'm inclined to wontfix this. Bug 1527749 would be needed, and that is probably non-trivial.

marking webext? for team consideration.

Flags: needinfo?(mixedpuppy)
Whiteboard: webext?
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(mixedpuppy)
Whiteboard: webext?
You need to log in before you can comment on or make changes to this bug.