1526320 - Make browser_inspector_highlighter-xbl.js use a test binding instead of a xul:tree

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Brian Grinstead [:bgrins]]

I attached https://phabricator.services.mozilla.com/D19087 to Bug 1523957 originally, but going to spin it off into a blocking bug to land separately.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1526320 - Convert DevTools XBL test to use a test binding instead of a xul:tree;r=pbro

This will unblock removing XBL for tree.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6d1ab19c941
Convert DevTools XBL test to use a test binding instead of a xul:tree;r=pbro

Comment 3

[Arthur Iakab [arthur_iakab]]

Backed out changeset c6d1ab19c941 (bug 1526320) for devtools failures on browser_inspector_highlighter-eyedropper-xul.js CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/a91f286b5b1f4df1f49254d6dd0e02d100139bc9

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=227202219&revision=c6d1ab19c941bac75643276575b476182c16bc7c

Log failure first the failures started on Test verify https://treeherder.mozilla.org/logviewer.html#?job_id=227205187&repo=autoland

And then migrated to tier 1 https://treeherder.mozilla.org/logviewer.html#?job_id=227205564&repo=autoland

:bgrins could you please take a look?

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1526320 - Convert DevTools XBL test to use a test binding instead of a xul:tree;r=pbro

This will unblock removing XBL for tree.

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Arthur Iakab [arthur_iakab] from comment #3)

Backed out changeset c6d1ab19c941 (bug 1526320) for devtools failures on browser_inspector_highlighter-eyedropper-xul.js CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/a91f286b5b1f4df1f49254d6dd0e02d100139bc9

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=227202219&revision=c6d1ab19c941bac75643276575b476182c16bc7c

Log failure first the failures started on Test verify https://treeherder.mozilla.org/logviewer.html#?job_id=227205187&repo=autoland

And then migrated to tier 1 https://treeherder.mozilla.org/logviewer.html#?job_id=227205564&repo=autoland

:bgrins could you please take a look?

Yep, sorry about that. Missed that another test used this helper file. Already pushed up a fix to phab.

Comment 6

[Brian Grinstead [:bgrins]]

Hm, there's a leak in debug builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33da341f1ec46a285663e39c1bc3f96f5d8f90db&selectedJob=227213600. Need to look into it.

Comment 7

[Brian Grinstead [:bgrins]]

I think because the <xbl:bindings> are visible it ends up realigning the host element and confusing windows debug builds. Switching the order of the tags seems to fix it. I also made a couple minor cleanups to the doc file.

Comment 8

[Brian Grinstead [:bgrins]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=07e9cad98d478fa08cf7e0b147eccb92a211728b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7f865d2159d
Convert DevTools XBL test to use a test binding instead of a xul:tree;r=pbro

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f7f865d2159d